Skip to content

"global" hybrid theory, plus two examples#947

Merged
fdupress merged 1 commit intomainfrom
step-hybrid
Mar 24, 2026
Merged

"global" hybrid theory, plus two examples#947
fdupress merged 1 commit intomainfrom
step-hybrid

Conversation

@alleystoughton
Copy link
Member

Added "step" hybrid theory, plus two examples. (Currently in temp directory in theories.)

@alleystoughton alleystoughton requested a review from fdupress March 22, 2026 23:40
Copy link
Member

@fdupress fdupress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Some comments.

Not approving yet because the examples are definitely not in the right place.

@alleystoughton alleystoughton changed the title "step" hybrid theory, plus two examples "global" hybrid theory, plus two examples Mar 23, 2026
@alleystoughton
Copy link
Member Author

I put GlobalHybrid.ec in theories/crypto.

Copy link
Member

@fdupress fdupress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have the existing hybrid refactored as an instance of this (in particular, avoiding repeating the proof for the telescoping sums), but this is fine to merge as it is.

@fdupress
Copy link
Member

Oh, sorry; not quite.

Please edit the commit message.

Something along the lines of

[theories/crypto] global hybrid theory

This adds a theory for hybrid arguments where the entire
experiment is parameterised, and two examples of how to
use it.

@fdupress
Copy link
Member

fdupress commented Mar 24, 2026

Generally, keeping the first line under 52 characters to indicate the "what", leaving a blank line, and keeping further lines under 80 characters to indicate the "why" is good practice.

Most people interact with git through the CLI client, which makes assumptions about commit messages and their formatting when displaying them. (Which are repeated in the github UI, hence why your commit titles get truncated after 52 characters.)

This adds a theory for hybrid arguments where the entire
experiment is parameterised. Two examples of its use are
also provided.
@alleystoughton
Copy link
Member Author

Would be nice to have the existing hybrid refactored as an instance of this (in particular, avoiding repeating the proof for the telescoping sums), but this is fine to merge as it is.

I can have a go this coming summer, if no-one gets to it before then.

@alleystoughton
Copy link
Member Author

Oh, sorry; not quite.

Please edit the commit message.

Something along the lines of

[theories/crypto] global hybrid theory

This adds a theory for hybrid arguments where the entire
experiment is parameterised, and two examples of how to
use it.

I changed the commit message, via git. Was there a way for me to do this without restarting all the checks?

@fdupress
Copy link
Member

No, but this is alright. I'll set auto-merge so this merges as soon as the checks succeed.

@fdupress fdupress enabled auto-merge (rebase) March 24, 2026 18:39
@fdupress fdupress merged commit ea0bde6 into main Mar 24, 2026
16 checks passed
@fdupress fdupress deleted the step-hybrid branch March 24, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants