Larger Events V4#3632
Open
LizardKing777 wants to merge 1 commit into
Open
Conversation
modified: src/game_character.h
modified: src/game_event.cpp
modified: src/game_map.cpp
modified: src/game_player.cpp
Fresh build off the latest upstream source. Adds checks Event triggering and Vehicle boarding/uboarding code to ensure new code is only executing when {_X} and/or {!Y} strings are detected.
Ghabry
reviewed
Jul 20, 2026
| } | ||
|
|
||
| // Note: RPG_RT ignores the lock_facing flag here! | ||
| if (vehicle->IsAscendingOrDescending()) return false; |
Member
There was a problem hiding this comment.
This is slowly getting at a reviewable stage.
Your commit contains various unrelated changes. Carefully look through your commit and fix them.
Imo this here is a good example: it changes the formatting and removes a comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh build off the latest upstream source. Adds checks Event triggering and Vehicle boarding/unboarding code to ensure new code is only executing when {_X} and/or {!Y} strings are detected.