reflect: check for sibling reflect-ci/fix-ci dispatches before finalizing - #4
Closed
EdbertChan wants to merge 1 commit into
Closed
reflect: check for sibling reflect-ci/fix-ci dispatches before finalizing#4EdbertChan wants to merge 1 commit into
EdbertChan wants to merge 1 commit into
Conversation
…zing Found while reflecting on Invoker CI job fleet/a71f331 (12 jobs): a single job had 3 separate workflow dispatches each independently authoring a near-identical unmerged fix to scripts/electron.cjs within a 2-hour window, and 4 separate reflect-ci-a71f331-* branches each running this skill's full lens fan-out against the same commit family. The dispatch-burst detector in multi-conversation mode already covers this shape, but its trigger assumes a human asks "why does X keep happening" -- an automated reflect-ci-* task has no human to ask, so it never fires there. Adds an unconditional git-branch check to step 1 and a matching "When to invoke" bullet for the automated-dispatch case.
EdbertChan
added a commit
that referenced
this pull request
Aug 18, 2026
All four predated the a7fc343 refactor (lens table moved to references/lenses.md) and had gone stale; ported their content onto the current structure and closing them in favor of this commit: - PR #1: path/file_path alias normalization in claude-mode dedup, edit-streak, and error-by-file detectors (+ both tests). The is_error half was already structural on main. 77/77 tests pass. - PR #2 (folded into #3 by its own description): step-6 unlanded-prior-draft check before writing a new lesson. - PR #3: step-3 sibling-transcript check, History-lens template-identical caution (now in references/lenses.md), step-6 commit-as-you-go. - PR #4: when-to-invoke bullet for automated reflect-ci runs + sibling branch grep folded into the step-3 sibling check.
Owner
Author
|
Landed on main in 9b9f97d — all four open PRs were written against the pre-a7fc343 SKILL.md layout and had gone stale (3 of 4 CONFLICTING). This PR's content was ported onto the current structure: see commit message for the per-PR mapping. Tests: 77/77 pass including this PR's two path-alias tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fleet / a71f331 (12 jobs): 3 separate workflow dispatches independently authored near-identical unmerged fixes to the same file within a 2-hour window, and 4 separatereflect-ci-a71f331-*branches each ran this skill's full lens fan-out against the same commit family.reflect-ci-*task has no human to ask, so it never fires in that context.git branch --all | grepsibling check to step 1 (locate transcripts) and a matching "When to invoke" bullet naming the automated-dispatch case.Test plan
Note
Low Risk
Documentation-only change to
skills/reflect/SKILL.mdwith no runtime or CI behavior changes.Overview
reflect skill prose now covers concurrent Invoker CI repair: several workflows can each open
fix-ci-*/reflect-ci-*chains for the same job id, which previously drove duplicate skill edits because dispatch-burst detection only fired when a human asked “why does X keep happening.”Adds a When to invoke bullet for automated
reflect-ci-*tasks: run the sibling check in step 1 without waiting for that question. In step 1 (Locate transcripts), adds Check for sibling reflect passes before finalizing — before spawning reviewers, rungit branch --all | grep -E "reflect-ci-<job-id>|fix-ci-<job-id>"and call out siblings in synthesis so the pass knows it may be one of several on the same commit family.No script or process-step renumbering; additive documentation only.
Reviewed by Cursor Bugbot for commit 5b9305a. Bugbot is set up for automated code reviews on this repo. Configure here.