fix(bw): rotary encoder mode and enabled features not working in radio setup page

[philmoz]

Fix radio setup page.
Broken in PR #7163

Fixes #7386, fixes #7410

Required in 2.11, 2.12 and 3.0.

Summary by CodeRabbit

• Bug Fixes
  • Adjusted the Radio Setup menu item layout and indexing across display configurations to ensure correct menu positioning and visual organization.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR adjusts menu item placeholder and conditional entry positions in the Radio Setup menu for 128x64 and 212x64 display variants. These changes correct the menu item-to-enum index mapping, fixing the RotEnc Mode selection issue where menu items became unhighlightable due to incorrect position tracking.

Changes

Radio Setup Menu Mapping

Layer / File(s)	Summary
128x64 Display Menu Indexing Adjustment radio/src/gui/128x64/radio_setup.cpp	Sound label entry replaces a prior placeholder at line 188, a new placeholder is inserted at line 231, and the conditional language slot sequence is reworked at lines 245–249 to realign subsequent menu item enum indices.
212x64 Display Menu Indexing Adjustment radio/src/gui/212x64/radio_setup.cpp	An additional placeholder entry is inserted at line 231 in the menu initializer to shift subsequent items into correct enum alignment.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	⚠️ Warning	The pull request description is incomplete and missing required template sections.	Add a detailed 'Summary of changes' section describing the menu item layout adjustments in both radio_setup.cpp files and their impact on menu indexing.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The PR correctly addresses issue #7386 by fixing menu item indexing in radio setup pages, restoring access to the RotEnc Mode option that was broken by PR #7163.
Out of Scope Changes check	✅ Passed	All changes are scoped to fixing the radio setup menu layout in both 128x64 and 212x64 display configurations, directly addressing the linked issue without unrelated modifications.
Title check	✅ Passed	The title accurately describes the main fix: restoring rotary encoder mode and feature functionality in the radio setup page, which aligns with the changeset modifying menu item initialization in radio_setup.cpp files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch philmoz/fix-rotenc-mode

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}