fix(pa01): Intermitten trim sounds#7414
Conversation
…fer on mute restart
Root cause: When 'Mute if no sound' is enabled and the DMA engine
restarts after a mute cycle, only half 0 of the circular double buffer
was filled (audio_update_dma_buffer(0)). Half 1 retained stale tone
data from the previous playback session, causing up to 10ms of replayed
audio that sounded like trim tones 'looping'.
Fix:
1. Move audioUnmute() before buffer-filling calls so the 100ms
RTOS_WAIT_MS doesn't block after consuming a FIFO buffer.
2. Add audio_update_dma_buffer(1) to initialize both halves of
the double buffer before starting circular DMA.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis PR introduces EdgeTX 2.11 "Jolly Mon" with comprehensive changes: new FlySky boards (PA01, PL18U, ST16) and HelloRadioSky V14 support; refactored data model reference handling and storage serialization; modernized build system with new bootloader wiring and bitmap generation; and improved simulator cross-platform launching, UI organization, and navigation state management. ChangesEdgeTX 2.11 Release: Board expansion, data model refactoring, and build modernization
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
|
|
Checked with PA01 and PL18U, seems better trim tones with mute and unmute |
Sometimes the trim tone cannot play properly. Problem discovered by opencode + deepseek v4, and seems works better.
Summary by CodeRabbit
Release Notes
New Features
Chores