Skip to content

fix(nv14/el18/pl18u): Telemetry RX DMA can be enabled for non-DAC audio radios#7417

Open
richardclli wants to merge 2 commits into
mainfrom
richardclli/fix-el18-pl18u-telerxdma
Open

fix(nv14/el18/pl18u): Telemetry RX DMA can be enabled for non-DAC audio radios#7417
richardclli wants to merge 2 commits into
mainfrom
richardclli/fix-el18-pl18u-telerxdma

Conversation

@richardclli
Copy link
Copy Markdown
Member

@richardclli richardclli commented Jun 1, 2026

Summary of changes:

Enable RX DMA for S.Port if non-DAC audio is used

Summary by CodeRabbit

  • Bug Fixes
    • Enabled telemetry functionality for specific radio hardware models, restoring reliable data transmission and improving monitoring for affected devices.

@richardclli richardclli added this to the 2.11.7 milestone Jun 1, 2026
@richardclli richardclli self-assigned this Jun 1, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 1, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a2ad1b8a-9be5-4cf9-86ad-7035c2a13404

📥 Commits

Reviewing files that changed from the base of the PR and between b47c0d7 and 6269f1d.

📒 Files selected for processing (1)
  • radio/src/targets/pl18/hal.h
🚧 Files skipped from review as they are similar to previous changes (1)
  • radio/src/targets/pl18/hal.h

📝 Walkthrough

Walkthrough

Hardware-specific telemetry DMA macros in radio/src/targets/pl18/hal.h are uncommented and conditionally defined when RADIO_NV14_FAMILY or RADIO_PL18U is set.

Changes

Telemetry DMA Configuration

Layer / File(s) Summary
Conditional telemetry DMA macros
radio/src/targets/pl18/hal.h
TELEMETRY_DMA_Stream_RX and TELEMETRY_DMA_Channel_RX are defined inside `#if defined(RADIO_NV14_FAMILY)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete. It lacks the issue reference (Fixes #) required by the template and provides minimal context. Add the issue number (Fixes #7417) at the top and expand with details about why this change is needed and which audio configurations are affected.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: enabling telemetry RX DMA for non-DAC audio radios in specific models.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch richardclli/fix-el18-pl18u-telerxdma

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pfeerick pfeerick added the backport/2.11 To be backported to a 2.11 release also. label Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/2.11 To be backported to a 2.11 release also.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants