Skip to content

fix(bw128): pot warning navigation#7422

Open
3djc wants to merge 1 commit into
mainfrom
3djc/fix-128-potwarning
Open

fix(bw128): pot warning navigation#7422
3djc wants to merge 1 commit into
mainfrom
3djc/fix-128-potwarning

Conversation

@3djc
Copy link
Copy Markdown
Collaborator

@3djc 3djc commented Jun 2, 2026

Fixes a navigation issue on 128 bw screen that made pot to be no selectable on model setup pre flight warnings

Fixes #7421

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an issue in the model setup menu where the switches warning layout would incorrectly adjust its position. The layout now properly adjusts only when actively selected by the user.

@3djc 3djc added B&W Related generally to black and white LCD radios backport/2.12 To be backported to a 2.12 release also. labels Jun 2, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 2, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

Condition refinement in MT12 pot warning handling: the workaround for single warning-capable switches now additionally requires the current cell to be actively selected before adjusting horizontal menu position, preventing unintended position shifts in inactive states.

Changes

MT12 Warning Switch Selection

Layer / File(s) Summary
Single-warning switch selection condition
radio/src/gui/128x64/model_setup.cpp
MT12 "single warning switch" workaround condition is tightened to require active cell selection (attr) before adjusting horizontal menu position, fixing non-selectable warning entries when only one warning-capable switch exists.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description identifies the issue and references the linked issue #7421, but lacks a structured summary of changes section as specified in the template.
Linked Issues check ✅ Passed The code change adds selection state checking (attr) to the pot warning layout logic, which directly addresses the inability to select pot positions reported in issue #7421.
Out of Scope Changes check ✅ Passed All changes are scoped to fixing the pot warning selection issue on BW 128 displays; no out-of-scope modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title 'fix(bw128): pot warning navigation' directly addresses the main change: fixing navigation issues for pot warnings on 128-pixel wide screens, which aligns with the PR objective of restoring pot selection functionality.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 3djc/fix-128-potwarning

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pfeerick pfeerick changed the title fix: BW 128 pot warning navigation fix(bw128): pot warning navigation Jun 3, 2026
@pfeerick pfeerick modified the milestones: 2.11.7, 2.12.2 Jun 3, 2026
@pfeerick pfeerick added the backport/2.11 To be backported to a 2.11 release also. label Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B&W Related generally to black and white LCD radios backport/2.11 To be backported to a 2.11 release also. backport/2.12 To be backported to a 2.12 release also.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MT12 EdgeTX v2.12.1 Pot warn not selectable

2 participants