Skip to content

fix(tx16smk3): allow invert flag for BSP, invert SI and SJ - 2.12#7426

Merged
pfeerick merged 1 commit into
2.12from
3djc/mk3-sisj-2.12
Jun 4, 2026
Merged

fix(tx16smk3): allow invert flag for BSP, invert SI and SJ - 2.12#7426
pfeerick merged 1 commit into
2.12from
3djc/mk3-sisj-2.12

Conversation

@3djc
Copy link
Copy Markdown
Collaborator

@3djc 3djc commented Jun 3, 2026

2.12 backport of #7425

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 3, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f3085b6f-8a03-4046-94c5-f44cb6c3de18

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 3djc/mk3-sisj-2.12

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@OzDruiD
Copy link
Copy Markdown

OzDruiD commented Jun 3, 2026

Thanks for this fix @3djc

I have imported the changed 2 files and re-built my own version of firmware (from main, with those changes) pending a full review and merge, but it works well - and all my models from MK2 - that I had not yet manually "inverted" to fix the issue - now automatically work.

The hardware debug screen also shows them working from both the momentary and latching switch types.

@pfeerick pfeerick added this to the 2.12.2 milestone Jun 4, 2026
@pfeerick pfeerick changed the title fix(TX116SMK3-2.12): invert SI/SJ fix(tx16smk3): allow invert flag for BSP, invert SI and SJ - 2.12 Jun 4, 2026
@pfeerick pfeerick merged commit a0fdca3 into 2.12 Jun 4, 2026
51 checks passed
@pfeerick pfeerick deleted the 3djc/mk3-sisj-2.12 branch June 4, 2026 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants