feat(Record): make fromIterableBy dual/pipeable#6111
Closed
mitre88 wants to merge 2 commits intoEffect-TS:mainfrom
Closed
feat(Record): make fromIterableBy dual/pipeable#6111mitre88 wants to merge 2 commits intoEffect-TS:mainfrom
mitre88 wants to merge 2 commits intoEffect-TS:mainfrom
Conversation
Make Record.fromIterableBy support both data-first and data-last (pipeable) calling conventions, consistent with fromIterableWith and other dual APIs in the Record module. Closes Effect-TS#6092
🦋 Changeset detectedLatest commit: 43661a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
Gentle ping — this feature PR to make |
Contributor
Author
|
Changeset added for this PR. Ready for review! |
Contributor
|
Hello! Effect v3 is under a feature freeze now. Feel free to contribute this to the v4 repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
Record.fromIterableBysupport both data-first and data-last (pipeable) calling conventions, consistent withRecord.fromIterableWithand other dual APIs in the Record module.Before
After
Closes #6092