fix: prevent cachedWithTTL from suppressing interruption of the cached effect#6316
Open
xianjianlf2 wants to merge 1 commit into
Open
fix: prevent cachedWithTTL from suppressing interruption of the cached effect#6316xianjianlf2 wants to merge 1 commit into
xianjianlf2 wants to merge 1 commit into
Conversation
…he cached effect Effect.cachedWithTTL and Effect.cachedInvalidateWithTTL ran the cached effect inside getCachedValue's uninterruptibleMask while populating the cache, which suppressed interruption-based combinators such as Effect.timeout. Restore the caller's interruptibility around the cached effect so it can be interrupted, matching the non-cached behaviour. Closes Effect-TS#6304
🦋 Changeset detectedLatest commit: 467b8d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
xianjianlf2
had a problem deploying
to
release-queue
GitHub Actions
Error
IMax153
added
the
3.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6304
Effect.cachedWithTTL/Effect.cachedInvalidateWithTTLrun the cached effect uninterruptibly:getCachedValuewraps populate-and-await incore.uninterruptibleMask, andcomputeCachedValueruns the user effect viacore.intoDeferred(self, deferred)under that mask — so interruption-based combinators likeEffect.timeoutcan never fire and the fiber hangs. (Effect.cachedis unaffected because it maps toeffect.memoize, a different path.)The mask's
restorewas only applied todeferredAwait, not to runningself. This threadsrestoreintocomputeCachedValueand applies it to the cached effect:it.livetests for both combinators asserting a timed-out cached effect yieldsExit.fail("Timeout"); without the fix they hang ~15s and fail.pnpm test run test/Effect/caching.test.ts→ 5 passed;pnpm --filter=effect checkclean. Changeset included.