Fix HasShadow Not Being true by Default#1049
Fix HasShadow Not Being true by Default#1049FlorianRappl merged 1 commit intoElectronNET:developfrom
HasShadow Not Being true by Default#1049Conversation
FlorianRappl
left a comment
There was a problem hiding this comment.
LGTM.
Personally, I would rather change the default / documentation to false. This way, there is nothing needed and it works as right now. However, imho changing it is fine to align with Electron's default behavior (and the previous documentation - so no one should be surprised by this from a documentation POV).
Makes sense since the default behavior has now changed. Though I'd argue that the default behavior so far was not working as intended (i.e., not as documented or expected from electron defaults), so this is more like a bug fix than a change in my opinion. |
|
Also, I only noticed this because on macOS the windows don't have any shadows by default. On Windows it seems that the window frame always has a shadow, regardless of that property (at least on Windows 10). But that might also depend on the other window customization settings. |
pr-comment: Run #69
🎉 All tests passed!Github Test Reporter by CTRF 💚 |
Fixes #1048