Skip to content

Fix HasShadow Not Being true by Default#1049

Merged
FlorianRappl merged 1 commit intoElectronNET:developfrom
AeonSake:1048-hasshadow-true-by-default
Mar 25, 2026
Merged

Fix HasShadow Not Being true by Default#1049
FlorianRappl merged 1 commit intoElectronNET:developfrom
AeonSake:1048-hasshadow-true-by-default

Conversation

@AeonSake
Copy link
Contributor

Fixes #1048

Copy link
Collaborator

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Personally, I would rather change the default / documentation to false. This way, there is nothing needed and it works as right now. However, imho changing it is fine to align with Electron's default behavior (and the previous documentation - so no one should be surprised by this from a documentation POV).

@AeonSake
Copy link
Contributor Author

Personally, I would rather change the default / documentation to false. This way, there is nothing needed and it works as right now. However, imho changing it is fine to align with Electron's default behavior (and the previous documentation - so no one should be surprised by this from a documentation POV).

Makes sense since the default behavior has now changed. Though I'd argue that the default behavior so far was not working as intended (i.e., not as documented or expected from electron defaults), so this is more like a bug fix than a change in my opinion.

@AeonSake
Copy link
Contributor Author

AeonSake commented Mar 25, 2026

Also, I only noticed this because on macOS the windows don't have any shadows by default. On Windows it seems that the window frame always has a shadow, regardless of that property (at least on Windows 10). But that might also depend on the other window customization settings.

@FlorianRappl FlorianRappl added this to the 0.5.0 milestone Mar 25, 2026
@FlorianRappl FlorianRappl merged commit 005fedd into ElectronNET:develop Mar 25, 2026
33 of 34 checks passed
@github-actions
Copy link

pr-comment: Run #69

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
1300 1156 0 0 0 144 0 5m 39s

🎉 All tests passed!

Github Test Reporter by CTRF 💚

@FlorianRappl FlorianRappl linked an issue Mar 25, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HasShadow Is Not true by Default

2 participants