Skip to content

Enabled >21m for issued assets in GUI amount field #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomt1664 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enabled >21m for issued assets in GUI amount field #1540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/qt/bitcoinamountfield.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,11 +124,11 @@ class AmountSpinBox: public QAbstractSpinBox
val.second = val.second + steps * currentSingleStep;
val.second = qMax(val.second, CAmount(0));
val.second = qBound(m_min_amount, val.second, m_max_amount);
// FIXME: Add this back in when assets can have > MAX_MONEY
// if (val.first == Params().GetConsensus().pegged_asset)
{
val.second = qMin(val.second, BitcoinUnits::maxMoney());
}
// ELEMENTS: issued assets can have values > MAX_MONEY
if (val.first == Params().GetConsensus().pegged_asset)
{
val.second = qMin(val.second, BitcoinUnits::maxMoney());
}
Comment on lines +128 to +131
Copy link
Member

@delta1 delta1 Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think your editor added some tabs here, not a blocking issue though

Suggested change
if (val.first == Params().GetConsensus().pegged_asset)
{
val.second = qMin(val.second, BitcoinUnits::maxMoney());
}
if (val.first == Params().GetConsensus().pegged_asset) {
val.second = qMin(val.second, BitcoinUnits::maxMoney());
}

setValue(val);
}

Expand Down Expand Up @@ -228,8 +228,8 @@ class AmountSpinBox: public QAbstractSpinBox
bool valid = GUIUtil::parseAssetAmount(current_asset, text, currentUnit, &val);
if(valid)
{
// FIXME: Add this back in when assets can have > MAX_MONEY
if (val < 0 || (val > BitcoinUnits::maxMoney() /*&& current_asset == Params().GetConsensus().pegged_asset*/)) {
// ELEMENTS: issued assets can have values > MAX_MONEY
if (val < 0 || (val > BitcoinUnits::maxMoney() && current_asset == Params().GetConsensus().pegged_asset)) {
valid = false;
}
}
Expand Down