Fix F541: replace f-strings with no placeholders in lightning tests#8929
Fix F541: replace f-strings with no placeholders in lightning tests#8929nikunjkumar05 wants to merge 2 commits intoElementsProject:masterfrom
Conversation
|
@rustyrussell @daywalker90 @Lagrang3 please review my PR |
|
You need to add "Changelog-None" to the PR or commit message. Otherwise looks good to me. |
|
ok sir |
|
@rustyrussell @daywalker90 @Lagrang3 |
|
@nikunjkumar05 thanks for your contribution. You haven't replaced all of the possible F541 (f-strings missing placeholders). There are a lot of different files that have this dev string. We will holding off reviewing further until the PR has all of the replacements required. |
|
Ok @madelinevibes thank you for review I will fix it shortly |
|
great that you've had a review but now @nikunjkumar05 you need to update so the PR passes CI. Thanks! |
|
Hi @nikunjkumar05, I am not approving the workflow to run just yet. Since the last commit is guaranteed to fail CI, running it now would just waste build minutes. Let's get all those fixes in first. |
|
Please rebase (not merge!) and squash everything into one clean commit when you're done. It's quite messy right now. Thanks! |
|
I think ready for review |
Changelog-None
About PR
This PR fixes flake8 F541 (f-strings missing placeholders) by replacing f-strings that contain no placeholders with plain strings in the lightning test files. These were lint errors only but reduce noise and avoid confusion.
Why
F541 indicates an f-string with no {} placeholders — likely a typo. Replacing with a plain string removes the lint error and clarifies intent.
How to Test
flake8 lightning/tests || true
Checklist