Parameterize odom and body frame IDs#74
Open
haasithp wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the hardcoded TF frame names (
camera_initand body) in laserMapping.cpp with ROS 2 parameters. This solves a major pain point by allowing the package to integrate seamlessly into standard robot TF trees (like setting them to odom andbase_link) without modifying the source code.Changes Made
odom_frameandbody_framevariables to laserMapping.cpp to handle TF broadcasts and PointCloud frame IDs dynamically instead of relying on string literals.common.odom_frameandcommon.body_framevia the parameter server.Backward Compatibility
Fully preserved.
We used
get_parameter_orto ensure the defaults perfectly match the old hardcoded values (camera_initand body). Existing users and datasets will experience no changed behavior, and theavia.yamltemplate uses the exact same frames as before.