Bugfix: runNames not saved#4896
Open
feyruzb wants to merge 1 commit into
Open
Conversation
feyruzb
force-pushed
the
bugfix/run-names-not-saved
branch
from
b3f7cd2 to
a089090
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the filter preset functionality by ensuring that the selected run names are correctly included when saving and retrieving report filter presets. It also updates the related tests to verify this new behavior.
Frontend changes:
ReportFilter.vue, the selected run names are now explicitly added to the filter state (runName), ensuring they are serialized and stored as part of the preset.Test updates:
test_filter_preset.pyare updated to:runNamein theReportFilterwhen creating and storing presets, and verify that this field is correctly saved and retrieved.