Skip to content

Add an exception for extendedFieldName #763

Open
Mr14huashao wants to merge 3 commits into
EsotericSoftware:masterfrom
Mr14huashao:kryo-699
Open

Add an exception for extendedFieldName #763
Mr14huashao wants to merge 3 commits into
EsotericSoftware:masterfrom
Mr14huashao:kryo-699

Conversation

@Mr14huashao

Copy link
Copy Markdown

Add a test case about boolean field for #699

@theigl

theigl commented Aug 30, 2020

Copy link
Copy Markdown
Collaborator

@Mr14huashao: As I said in #759, we need a solution with minimal overhead. Ideally, the duplicate field check would be done only once when the serializer is first initialized. I think we should only log a warning so we do not break existing applications and force them to use extendedFieldNames.

Comment thread src/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializer.java Outdated
Comment thread src/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializer.java Outdated
Comment thread src/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializer.java Outdated
Comment thread test/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializerTest.java Outdated
@Mr14huashao

Copy link
Copy Markdown
Author

@theigl Thank you for checking my code.
Based on the suggestion you provided, I modified some code, and the code is better.
I've benefited a lot from it.
Thank you very much.

@theigl theigl left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mr14huashao: Sorry for the delay. I just reviewed your PR.

Please adjust your tests to use existing support from KryoTestCase and change your tests to look like others in the same file.

Comment thread test/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializerTest.java Outdated
Comment thread test/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializerTest.java Outdated
Comment thread test/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializerTest.java Outdated
Comment thread test/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializerTest.java Outdated
Comment thread test/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializerTest.java Outdated
Comment thread src/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializer.java Outdated
Comment thread src/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializer.java Outdated
Comment thread src/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializer.java Outdated
Comment thread src/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializer.java Outdated
Comment thread src/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializer.java Outdated
Comment thread src/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializer.java Outdated
Comment thread test/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializerTest.java Outdated
@theigl

theigl commented Nov 2, 2020

Copy link
Copy Markdown
Collaborator

@Mr14huashao: I'm currently trying to stabilize Kryo 5.0.0 and will merge only bug fix PRs in the near future. Let's revisit this after Kryo 5.0.1 has been released.

@Mr14huashao

Copy link
Copy Markdown
Author

@theigl Do I want to modify some content based on the current version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants