[pull] master from beyond-all-reason:master#29
Merged
Conversation
Previously a map had to have a skybox texture right from the start for it to be usable. Now sets it up at runtime.
Under UNITSYNC and DEDICATED, TimeCheck compiled to `return 0`, silently dropping the function it was handed. The shipped gamedata/defs.lua wraps all unitdef/weapondef/etc. loading in Spring.TimeCheck(...), so ProcessUnits() ends up with an empty root and throws "root unitdef table invalid" - unitsync reports zero units for every game whose defs.lua uses TimeCheck (the standard springcontent path). Only the profiling timer needs to be excluded from those builds, not the call itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )