feat: derive report-load skeleton gates from the request queue#96395
Draft
BartekObudzinski wants to merge 1 commit into
Draft
feat: derive report-load skeleton gates from the request queue#96395BartekObudzinski wants to merge 1 commit into
BartekObudzinski wants to merge 1 commit into
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The initial report-load skeleton on a few report surfaces reads the stored
isLoadingInitialReportActionsflag. Like other stored loading flags, it is a shadow of the request queue and can be stranded by a reload or dropped response, leaving the skeleton up with no request running.This change moves the clean, screen-level consumers onto the queue-derived, per-report
useIsReportLoadPending(reportID)hook, which reads whether anOpenReportrequest for that report is currently in the SequentialQueue. The flag is set and cleared atomically with that request, so healthy-path behavior is identical.The hook now also accepts
reportID: string | undefined(an undefined scope key never matches a realOpenReport, so it reads as "not loading") to avoid defaulting the id to a sentinel value where a caller's reportID is optional.Scope is deliberately narrow: only consumers that read the flag as a plain, screen-level skeleton gate for a single report. Consumers with completion semantics (
=== false), default-trueguards, per-row render paths, transition trackers, or pure utilities that take the state as a parameter are intentionally left on the flag. The flag and its writers are untouched — removal is a separate change.Migrated: MoneyReportHeaderNextStep, MoneyRequestReportView, ReportFooter.
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari