Render the 30-day broken card connection messages#96409
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Explanation of Change
Frontend rendering for two new report actions the backend posts 30 days after a card connection breaks (if it's still broken):
COMPANYCARDCONNECTIONBROKEN30DAYS(workspace #admins room) andPERSONALCARDCONNECTIONBROKEN30DAYS(Concierge DM). They render like the existing broken-connection actions (a muted system message with an inline "Log into your bank" link) but with copy that says the connection has been broken for 30 days and offers to remove the card/connection.Opening as a draft: these actions only appear once the backend (Auth + Web-Expensify) ships, so this rides behind those PRs.
Backend plan: https://github.com/Expensify/Expensify/issues/658860
Auth PR: https://github.com/Expensify/Auth/pull/23010
Web-Expensify PR: https://github.com/Expensify/Web-Expensify/pull/54641
Fixed Issues
$ #88240
PROPOSAL: N/A (assigned engineering task, backend-driven)
Tests
COMPANYCARDCONNECTIONBROKEN30DAYSaction and verify it renders "The {feed} connection has been broken for 30 days. Log into your bank to fix it or remove the connection if it's no longer in use. You won't lose any submitted expenses if you remove it." with a tappable "Log into your bank" link to the workspace company cards page.PERSONALCARDCONNECTIONBROKEN30DAYSaction and verify it renders "Your {card} connection has been broken for 30 days. Log into your bank to fix it or remove the card if it's no longer in use. You won't lose any submitted expenses if you remove it." with a tappable link to the personal card details page (when the card is still broken).Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari