[No QA] Updates to ECUK setup docs for formatting and instructions #96438
[No QA] Updates to ECUK setup docs for formatting and instructions #96438stephanieelliott wants to merge 5 commits into
Conversation
…nd-Manage-the-Expensify-Card-US.md
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@mjasikowski @bfitzexpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] NOTE: It looks like |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0f60a8c82e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| After activation, the card is ready to use. | ||
|
|
||
| ## How do I change my PIN? | ||
| For details on how to set, view, change, or unblock an Expensify Card's PIN, see [Manage Your Expensify Card PIN (GBP/EUR Cards Only)](/articles/new-expensify/expensify-card/Manage-Your-Expensify-Card-PIN). |
There was a problem hiding this comment.
Point PIN instructions at an existing article
When UK/EU cardholders follow this new PIN-management link, it will 404 because the commit removes the inline PIN FAQ but does not add docs/articles/new-expensify/expensify-card/Manage-Your-Expensify-Card-PIN.md or a redirect for that slug; a repo-wide file search only finds this reference and an unrelated chat pin article. Either add the target article/redirect or keep the PIN steps in this page.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
PIN article is being published at the same time: #89154 (
|
HelpDot Documentation Review Overall Assessment Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
A preview of your ExpensifyHelp changes have been deployed to https://ce5510e8.helpdot.pages.dev ⚡️ Updated articles: |
rafecolton
left a comment
There was a problem hiding this comment.
Approving in case we need to merge and do a follow-up, but I do spot some minor issues
| 7. In your conversation with Concierge, provide the most recent three months of bank statements for the bank account you selected in Step 5. These statements help determine your workspace's eligible spending limit. | ||
|
|
||
| Link a GBP or EUR business bank account that will be used to pay the card balance either daily or monthly. | ||
| Concierge reviews your request and contacts you if any additional information is needed. Approval typically takes one to two business days. Once your workspace is approved, you can begin issuing Expensify Cards. |
There was a problem hiding this comment.
Minor NAB
| Concierge reviews your request and contacts you if any additional information is needed. Approval typically takes one to two business days. Once your workspace is approved, you can begin issuing Expensify Cards. | |
| Concierge will review your request and contact you if any additional information is needed. Approval typically takes one to two business days. Once your workspace is approved, you can begin issuing Expensify Cards. |
We should probably set some expectations about Trulioo and KYB, right? That can be quick if all the info is there, but I'm not sure it will always be 1-2 business days.
| 1. In the navigation tabs (on the left on web, at the bottom on mobile), select **Workspaces > [workspace name] > Expensify Card**. | ||
| 2. Click **Issue new card**. | ||
| 3. Select the member. | ||
| 3. Select the member who will receive the card. |
There was a problem hiding this comment.
NAB virtual cards are not received per se
| 3. Select the member who will receive the card. | |
| 3. Select the member who will be assigned the card. |
| After activation, the card is ready to use. | ||
|
|
||
| ## How do I change my PIN? | ||
| For details on how to set, view, change, or unblock an Expensify Card's PIN, see [Manage Your Expensify Card PIN (GBP/EUR Cards Only)](/articles/new-expensify/expensify-card/Manage-Your-Expensify-Card-PIN). |
There was a problem hiding this comment.
It would be good for that article to talk about pin unblock, but as of this moment, it does not mention it anywhere user-facing
| For details on how to set, view, change, or unblock an Expensify Card's PIN, see [Manage Your Expensify Card PIN (GBP/EUR Cards Only)](/articles/new-expensify/expensify-card/Manage-Your-Expensify-Card-PIN). | |
| For details on how to set, view, or change an Expensify Card's PIN, see [Manage Your Expensify Card PIN (GBP/EUR Cards Only)](/articles/new-expensify/expensify-card/Manage-Your-Expensify-Card-PIN). |
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari