Add internal Billing & Subscriptions topic index for help authors#96439
Add internal Billing & Subscriptions topic index for help authors#96439MelvinBot wants to merge 1 commit into
Conversation
Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://62ead47f.helpdot.pages.dev ⚡️ Updated articles: |
|
The only failing check is PR Author Checklist / checklist — every other check (build, verify, validate, spellcheck, dryRun, CLA, verifySignedCommits) is passing. ✅ That check isn't a code failure. It fails because the author checklist boxes are unchecked:
There's nothing in the code to fix or push here — the checklist is meant to be completed by the human author/co-author, and I don't check those boxes on anyone's behalf. Once you (as the co-author) review the changes, fill out the Tests / QA Steps sections, and check off the applicable items in the PR Author Checklist, that check will pass. |
Explanation of Change
Adds a new internal reference file,
docs/topic-index.md, that maps commonly referenced New Expensify Billing & Subscriptions topics to their canonical article + section anchor.This index is for help content authors, not members — it is intentionally placed at the
docs/root (not underdocs/articles/), so it is not a routed, published help article. Its purpose is to give authors one canonical place to link whenever a topic (a role, definition, setting, eligibility rule, or workflow) is referenced from another article, instead of re-explaining it.What it contains:
Workspace owner / billing owner).## Gapssection for topics that are referenced across articles but lack a clear canonical home in this folder (deleting a workspace to stop billing, invoiced subscriptions, free trial).No existing articles were modified and no new member-facing content was created.
Every article path and heading anchor was validated against the actual headings in
docs/articles/new-expensify/billing-and-subscriptions/, and the anchor style (kramdown: lowercase, spaces → hyphens, punctuation stripped) matches the existing cross-article links already used in the repo (e.g.#what-is-a-workspace-owner).Fixed Issues
$ https://github.com/Expensify/Expensify/issues/661288
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
This PR adds a single non-routed internal Markdown file (
docs/topic-index.md). It is not a published help article and does not affect app code, docs routing, or the JS console. Suggested review check: open the file and spot-check that the linked article paths + anchors resolve to the intended sections.Offline tests
N/A — internal documentation file only.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari