Skip to content

Search - Load categories from all workspaces#96460

Draft
ShridharGoel wants to merge 2 commits into
Expensify:mainfrom
ShridharGoel:fix/661264-search-category-filters-app
Draft

Search - Load categories from all workspaces#96460
ShridharGoel wants to merge 2 commits into
Expensify:mainfrom
ShridharGoel:fix/661264-search-category-filters-app

Conversation

@ShridharGoel

@ShridharGoel ShridharGoel commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Load lightweight category data for every workspace only when the Category filter opens. Merge it with full category data already stored in Onyx so category rules and optimistic updates remain unchanged.

This makes categories from non-default workspaces available in the Spend filters without increasing the initial Search response. The new collection contains only the category name and enabled state to keep the response small.

Companion Auth PR: https://github.com/Expensify/Auth/pull/23042

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/661264
PROPOSAL:

Tests

  1. Sign in with an account that belongs to multiple workspaces, has many categories and has a category unique to a non-default workspace
  2. Open Spend and select Filters > Category
  3. Verify the unique category appears without changing the default workspace
  4. Select one workspace in the Workspace filter
  5. Verify the Category filter only shows categories from that workspace
  6. Clear the Workspace filter and verify categories from all workspaces appear again
  • Verify that no errors appear in the JS console

Offline tests

  1. Complete the online steps so category filter data is stored in Onyx
  2. Go offline and reopen Spend > Filters > Category
  3. Verify the previously loaded categories remain available

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using that component are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG assets, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that these changes do not break usages of that component in the rest of the App
  • If the PR modifies a component related to any existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page accessible by a direct deeplink, I verified the code functions as expected when the deeplink is used from logged-in and logged-out accounts.
  • If the PR modifies the UI or form input styles:
    • I verified that all inputs inside a form are aligned.
    • I added the Design label or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for this bug fix.
  • If main was merged into this PR after review, I tested again and verified the expected outcome.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Use lightweight search data without replacing full category rules or optimistic state.

Refs Expensify/Expensify#661264
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant