Release/v2.24.2#1060
Merged
Merged
Conversation
When replicating a rule, the wizard's initialization effect was calling setDefaultInclusions on the cloned rule, overwriting the source's sharing/users/orgUnits include-objects-and-references flags with the user's default inclusion config. The clone then ran without pulling those dependencies. Skip the defaults branch when a replicated rule is present in location.state.
Nested copies of @dhis2/prop-types under various @dhis2-ui packages do not export a default, but @dhis2-ui/ui-icons (e.g. Add16.js) imports it as default. Rollup resolved imports to the nested copies and failed with "default is not exported". Deduping forces resolution to the top-level @dhis2/prop-types which has the default export.
BundleMonNo change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the v2.24.2 release to
master. This PR contains exactly the commits that are in the v2.24.2 release — nothing else fromdevelopment.What's included
Cherry-picked on top of
v2.24.0(the previousmastertip):@dhis2/prop-typescopies don't expose a default export and tripped RollupRelease notes
v2.24.1 — Fix sync rule replication overwriting inclusion options (sharing, users, organisation units) with defaults (#1059)
v2.24.2 — Fix "Select All" in metadata table unselecting selections from other metadata types (#1048)