Use unreleased websocket.io commit (Node 7 EventEmitter)#1
Merged
Conversation
added 3 commits
January 17, 2017 21:00
Owner
Author
|
Fixed |
F1LT3R
changed the title
kbirken
added a commit
to franca/franca
that referenced
this pull request
Mar 7, 2017
kbirken
added a commit
to kbirken/franca-html5-showcase
that referenced
this pull request
Mar 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Websocket.io has a problem using the event emitter prototype as of changed to how Node 7 accesses events. It is not yet released, but you can follow updates here: LearnBoost/websocket.io#57
I set the commit of the depedency in
package.jsonto be the specific commit of websocket.io that is work (but remains unreleased).