Add customized directories issues/21 by NonaSuomy · Pull Request #37 · FREEWING-JP/Build-Fritzing-1.0.0-Windows-script

NonaSuomy · 2025-04-28T15:55:34Z

added directories_config.bat

… paths

directories_config

C: drive default

line endings

NonaSuomy · 2025-07-03T02:12:55Z

Any issues with this now?
Changed all the files to lf instead of crlf which seems strange as it's windows scripting not unix.

Update lf

NonaSuomy · 2025-07-05T10:22:29Z

Is there anything else you want done or good 2 go?

pizzapi2012 · 2025-07-24T19:55:36Z

@FREEWING-JP ?

FREEWING-JP · 2025-08-17T04:58:38Z

I will check contents .

FREEWING-JP

First , I pointed out the parts that concerned me .

FREEWING-JP · 2025-09-06T04:03:36Z

 echo %0
-cd /d \00_fritzing
+rem Load configuration
+if exist directories_config.bat call directories_config.bat


if exist directories_config.bat call directories_config.bat
cange to
call directories_config.bat

The directories_config.bat file always exists, so there is no need to check for its existence .
Of course , this also applies to batch files 01 to 20 .

FREEWING-JP · 2025-09-06T04:28:06Z

+rem Load configuration from directories_config.bat if it exists
+rem Otherwise, use default values
+if exist directories_config.bat (
+    echo Loading configuration from directories_config.bat
+    call directories_config.bat
+) else (
+    echo directories_config.bat not found, creating with default values
+    rem Configure Qt installation directory (default is C:\Qt)
+    if "%QT_INSTALL_DIR%" == "" set QT_INSTALL_DIR=C:\Qt
+
+    rem Configure Fritzing workspace directory (default is \00_fritzing)
+    if "%FRITZING_WORKSPACE_DIR%" == "" set FRITZING_WORKSPACE_DIR=\00_fritzing
+
+    rem Configure Visual Studio installation directory
+    if "%VS_INSTALL_DIR%" == "" set VS_INSTALL_DIR=C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools
+
+    rem Create the configuration file
+    echo @echo off> directories_config.bat
+    echo rem directories_config.bat>> directories_config.bat
+    echo rem Configuration file for directory paths used in Fritzing build scripts>> directories_config.bat
+    echo rem This file is meant to be persistent and can be edited manually>> directories_config.bat
+    echo.>> directories_config.bat
+    echo rem Qt installation directory>> directories_config.bat
+    echo set QT_INSTALL_DIR=%QT_INSTALL_DIR%>> directories_config.bat
+    echo.>> directories_config.bat
+    echo rem Fritzing workspace directory>> directories_config.bat
+    echo set FRITZING_WORKSPACE_DIR=%FRITZING_WORKSPACE_DIR%>> directories_config.bat
+    echo.>> directories_config.bat
+    echo rem Visual Studio installation directory>> directories_config.bat
+    echo set VS_INSTALL_DIR=%VS_INSTALL_DIR%>> directories_config.bat
+)


rem Load configuration from directories_config.bat if it exists rem Otherwise, use default values if exist directories_config.bat ( ... echo set VS_INSTALL_DIR=%VS_INSTALL_DIR%>> directories_config.bat )

change to
call directories_config.bat

Because Will change it to do the same processing in directories_config.bat , so can delete this section .

FREEWING-JP · 2025-09-06T04:34:27Z

+rem Update directories_config.bat if it already exists
+if not exist directories_config.bat (
+    rem Create the configuration file
+    echo @echo off> directories_config.bat
+    echo rem directories_config.bat>> directories_config.bat
+    echo rem Configuration file for directory paths used in Fritzing build scripts>> directories_config.bat
+    echo rem This file is meant to be persistent and can be edited manually>> directories_config.bat
+    echo.>> directories_config.bat
+    echo rem Qt installation directory>> directories_config.bat
+    echo set QT_INSTALL_DIR=%QT_INSTALL_DIR%>> directories_config.bat
+    echo.>> directories_config.bat
+    echo rem Fritzing workspace directory>> directories_config.bat
+    echo set FRITZING_WORKSPACE_DIR=%FRITZING_WORKSPACE_DIR%>> directories_config.bat
+    echo.>> directories_config.bat
+    echo rem Visual Studio installation directory>> directories_config.bat
+    echo set VS_INSTALL_DIR=%VS_INSTALL_DIR%>> directories_config.bat
+    echo.>> directories_config.bat
+    echo rem Created by 00_Download_Script.bat>> directories_config.bat
+)


I think this section is not need .
Because directories_config.bat file always exists .

FREEWING-JP · 2025-09-06T04:38:23Z

+rem Qt installation directory (default is C:\Qt)
+set QT_INSTALL_DIR=C:\Qt


rem Qt installation directory (default is C:\Qt) set QT_INSTALL_DIR=C:\Qt

change to

rem Configure Qt installation directory (default is C:\Qt) if "%QT_INSTALL_DIR%" == "" set QT_INSTALL_DIR=C:\Qt

FRITZING_WORKSPACE_DIR VS_INSTALL_DIR

Change these as well .

FREEWING-JP · 2025-09-06T04:39:06Z

+set VS_INSTALL_DIR=C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools
+
+rem Additional configuration variables can be added here
+


add

echo Using Qt installation directory: %QT_INSTALL_DIR% echo Using Fritzing workspace directory: %FRITZING_WORKSPACE_DIR% echo Using Visual Studio directory: %VS_INSTALL_DIR%

FREEWING-JP · 2025-09-06T04:43:27Z

-
+pause


It is abnormal for differences to occur in this location .
Please return to a state where there are no differences .
(When there are strange differences like this , I lose the desire to review .)

FREEWING-JP · 2025-09-06T09:01:16Z

I think this should be done in one commit .
Commits like this that go against my style make me less willing to review them .

NonaSuomy and others added 12 commits April 22, 2025 05:19

Add files via upload

601983b

Update 00_Download_Script.bat

8946f43

Update README.md

675119b

Update README.md

0caf031

Implement persistent directories_config.bat for Qt, workspace, and VS…

afdfca0

… paths

Added directories_config.bat

eb461fa

Update 00_Execute_Script.bat

f68f2a8

directories_config

Update 02_Download_Requirement_Files.bat

4f8e46a

Update 03_Install_Qt_653.bat

988f6ce

Update 05_Extract_Requirement_Files.bat

6401065

Update 06_Download_from_Git.bat

d93a8b1

Update directories_config.bat

af0a580

C: drive default

FREEWING-JP reviewed Apr 29, 2025

View reviewed changes

Comment thread SendKeys_Accept.vbs

FREEWING-JP reviewed Apr 29, 2025

View reviewed changes

Comment thread 00_Download_Script.bat

NonaSuomy added 7 commits April 29, 2025 10:05

Delete SendKeys_AltF4.vbs

971eca0

Delete SendKeys_Accept.vbs

0341661

fixed line endings

10bc39d

Update 00_Download_Script.bat

59fdcbe

line endings

Update 00_Download_Script.bat

9ff341b

Add files via upload

36108f5

Merge branch 'main' into pr-36

cfa48bf

NonaSuomy changed the title ~~Pr 36~~ Add customized directories issues/21 Jul 3, 2025

NonaSuomy added 7 commits July 2, 2025 22:48

Update lf

11fd560

Update lf

Delete 05_Extract_Requirement_Files.bat.bak

5f2e25f

Delete 09_Download_Fritzing_Source_code.bat.bak

44e7281

Delete 08_Fix_Library_place_Fritzing.bat.bak

fbcf4ea

Delete 07_Build_Library.bat.bak

ba7b84c

Delete 06_Download_from_Git.bat.bak

f574f04

Delete 04_Install_Visual_Studio_Build_Tools_2019.bat.bak

4a6af03

NonaSuomy added 24 commits July 3, 2025 11:42

Update 00_Execute_Script.bat

bdb8714

Update 01_Create_Build_directory.bat

66936bf

Update 03_Install_Qt_653.bat

9cff7b2

Update 04_Install_Visual_Studio_Build_Tools_2019.bat

581d157

Update 05_Extract_Requirement_Files.bat

54596d9

Update 06_Download_from_Git.bat

d5e56f7

Update 07_Build_Library.bat

c09743d

Update 08_Fix_Library_place_Fritzing.bat

e501059

Update 09_Download_Fritzing_Source_code.bat

ed8d5bf

Update 10_Download_Fritzing_Parts_Library.bat

4275e36

Update 11_Fix_Fritzing_Source_code.bat

e673699

Update 12_Fix_Fritzing_Header_files.bat

7c557de

Update 13_Build_phoenix_pro_with_Qt.bat

969229e

Update 15_Copy_Fritzing_Requirement_DLL_files.bat

fef0f43

Update 16_Copy_Qt_Requirement_DLL_files.bat

fec49b1

Update 17_1st_Build_Parts_DB_file.bat

cb56769

Update 18_2nd_Launch_Fritzing.bat

d92e792

Update 19_Organize_unnecessary_files.bat

beb97f7

Update 20_Create_Fritzing_zip_package.bat

bf00874

Update LICENSE

5c0bbff

Update README.md

bdfec2f

Update directories_config.bat

6c77404

Update README.md

a07e2f1

Update 00_Execute_Script.bat

8a4d657

NonaSuomy requested a review from FREEWING-JP July 4, 2025 05:04

FREEWING-JP reviewed Sep 6, 2025

View reviewed changes

		rem Qt installation directory (default is C:\Qt)
		set QT_INSTALL_DIR=C:\Qt

		set VS_INSTALL_DIR=C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools

		rem Additional configuration variables can be added here


		pause No newline at end of file

Conversation

NonaSuomy commented Apr 28, 2025

Uh oh!

Uh oh!

Uh oh!

NonaSuomy commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NonaSuomy commented Jul 5, 2025

Uh oh!

pizzapi2012 commented Jul 24, 2025

Uh oh!

FREEWING-JP commented Aug 17, 2025

Uh oh!

FREEWING-JP left a comment

Choose a reason for hiding this comment

Uh oh!

FREEWING-JP Sep 6, 2025

Choose a reason for hiding this comment

Uh oh!

FREEWING-JP Sep 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FREEWING-JP Sep 6, 2025

Choose a reason for hiding this comment

Uh oh!

FREEWING-JP Sep 6, 2025

Choose a reason for hiding this comment

Uh oh!

FREEWING-JP Sep 6, 2025

Choose a reason for hiding this comment

Uh oh!

FREEWING-JP Sep 6, 2025

Choose a reason for hiding this comment

Uh oh!

FREEWING-JP Sep 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FREEWING-JP commented Sep 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NonaSuomy commented Jul 3, 2025 •

edited

Loading

FREEWING-JP Sep 6, 2025 •

edited

Loading

FREEWING-JP Sep 6, 2025 •

edited

Loading