The $newTags object should clone $resource tags collection.#21
Open
bzis wants to merge 2 commits into
Open
Conversation
For example we have a resource with tags 'aaa' ,'bbb'; Then we want to change tags to 'bbb', 'ccc'; $newTags = $resource->getTags(); $tagsToAdd = $newTags; Then we remove 'bbb' tag from $tagsToAdd ($tagsToAdd->removeElement($oldTag)), because we don't need to add this tag, it already exists. But oops, it is also removed from $resource and the $resource->getTags() collection is not actual.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The $newTags object should clone $resource tags collection.
For example we have a resource with tags 'aaa' ,'bbb';
Then we want to change tags to 'bbb', 'ccc';
$newTags = $resource->getTags();
$tagsToAdd = $newTags;
Then we remove 'bbb' tag from $tagsToAdd ($tagsToAdd->removeElement($oldTag)), because we don't need to add this tag, it already exists. But oops, it was also removed from $resource and the $resource->getTags() collection becomes not actual.