Skip to content

Replace SpellList with TreeList in ListIota#1032

Merged
Robotgiggle merged 3 commits into
FallingColors:1.21from
s5bug:vector-fixes-3
Jul 15, 2026
Merged

Replace SpellList with TreeList in ListIota#1032
Robotgiggle merged 3 commits into
FallingColors:1.21from
s5bug:vector-fixes-3

Conversation

@s5bug

@s5bug s5bug commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@s5bug s5bug force-pushed the vector-fixes-3 branch from cef264d to aa476d4 Compare May 6, 2026 08:12
@s5bug s5bug marked this pull request as ready for review May 6, 2026 08:13
@s5bug s5bug force-pushed the vector-fixes-3 branch from aa476d4 to 14359e7 Compare May 10, 2026 19:08
@s5bug s5bug changed the base branch from main to 1.21 June 7, 2026 20:31
@s5bug s5bug force-pushed the vector-fixes-3 branch from 14359e7 to a2bcfc7 Compare June 7, 2026 21:32
@s5bug s5bug marked this pull request as draft June 7, 2026 21:32
@s5bug s5bug marked this pull request as ready for review June 11, 2026 19:25
@s5bug s5bug force-pushed the vector-fixes-3 branch 3 times, most recently from 260cf3a to 40ccf3c Compare June 12, 2026 01:59

@Robotgiggle Robotgiggle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: the changes to this file seem to be unnecessary

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh: they're probably a remnant of a future PR that got split.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Robotgiggle I don't have a good PC right now: would you be willing to rebase -i and edit the commit that makes these changes to remove them, and force-push to my branch?

@Robotgiggle Robotgiggle added this pull request to the merge queue Jul 15, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 15, 2026
@Robotgiggle Robotgiggle added this pull request to the merge queue Jul 15, 2026
Merged via the queue into FallingColors:1.21 with commit 37662e6 Jul 15, 2026
5 of 8 checks passed
@github-project-automation github-project-automation Bot moved this to ✅ Done in Hex Casting Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants