Refactor migration specs - #577
Open
ITaluone wants to merge 3 commits into
Open
Conversation
ITaluone
force-pushed
the
refactor-migration-specs
branch
from
July 27, 2026 06:16
b3517e9 to
0c8d921
Compare
ITaluone
force-pushed
the
refactor-migration-specs
branch
from
July 27, 2026 06:24
0c8d921 to
1434e95
Compare
5 tasks
ITaluone
force-pushed
the
refactor-migration-specs
branch
from
July 27, 2026 06:30
1434e95 to
ce1f0e6
Compare
ITaluone
force-pushed
the
refactor-migration-specs
branch
from
July 27, 2026 06:44
ce1f0e6 to
8032c64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors all
Fallout.Migrate.Specsstep tests to exercise the fullMigrationpipeline instead of calling steps directly, and applies the AV1600 behavior-focused naming convention.What changed
RewriteCsprojsStepSpecs,RewriteCsFilesStepSpecs,BumpDotNetVersionStepSpecs,ScriptRewriterSpecsnow write real files to a temp directory, run them throughMigration.RunAsync(), and assert on the file content read back, instead of callingRewriteCsprojsStep/RewriteCsFilesStep/BumpDotNetVersionStep/ScriptRewriterdirectly.[Fact]/[Theory]methods inRewriteCsFilesStepSpecs,BumpDotNetVersionStepSpecs, andScriptRewriterSpecsto short, present-tense, snake_case descriptions of observable behavior, matching docs/agents/conventions.md's AV1600 convention already used elsewhere.Why?
Calling steps in isolation let the specs drift from what the real migration pipeline produces (e.g. hardcoded version strings that don't match
ResolveFalloutVersionStep's live resolution.Verification
Additional things to mention:
Does not refactor the
BumpDotNetVersionStepSpecsin favor of #572From: #519 (comment)