Remove the completed rebrand plan - #591
Draft
ChrisonSimtian wants to merge 1 commit into
Draft
Conversation
docs/rebrand-plan.md was the working plan for the Nuke.* → Fallout.* rename. That rename has landed, so the document now describes finished work — and reads to AI coding tools as a live plan they are expected to keep current. Parts of it are already wrong: the shim sunset timeline is anchored to a "first Fallout.<X> 11.x release" that never shipped, and the project↔namespace mismatch table describes the pre-rename tree. Git history keeps the decision record. The two facts still worth having are kept where they are used rather than in a plan document: - The strict 1:1 prefix-swap rule, and why [TypeForwardedTo] locks it, moves into the rebrand-status paragraph in AGENTS.md. - The reason the CLI's PackageId diverges from its assembly name already lives in Fallout.Cli.csproj. Inbound references repointed: - AGENTS.md ×2 — the namespace-mapping pointer, and the "where to look next" bullet, which now points at the migration guide instead. - docs/migration/from-nuke.md — the "why the rename" link now goes to README#based-on-nuke, which is where that explanation actually lives. - NukeMigrationAnalyzer.helpLinkUri — this one shipped to consumers as the diagnostic's help link, so it would have 404'd. Now points at the migration guide, which is the actionable page for that diagnostic. - Fallout.Migrate.Analyzers/README.md — deep-linked the dead #sunset-timeline anchor. Restated: shim removal is a breaking change and lands at a yearly major cut, undated, with a note on why the old "remove in 12.0" plan no longer applies. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ChrisonSimtian
added
documentation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete
docs/rebrand-plan.md. Requested in review on #581 — it describes finished work, and reads to AI tools as a live plan they need to keep current.It is also already stale in places: the shim sunset timeline is anchored to a "first
Fallout.<X>11.x release" that never shipped, and the project↔namespace mismatch table describes the pre-rename tree. Git history keeps the decision record.Not a clean delete
Five inbound references, one of them shipped:
AGENTS.md— namespace-mapping pointer[TypeForwardedTo]reason are inlined into the rebrand-status paragraphAGENTS.md— "where to look next" bulletdocs/migration/from-nuke.mddocs/migration/from-nuke.md— "why the rename"README#based-on-nuke, where that explanation actually livesNukeMigrationAnalyzer.helpLinkUridocs/migration/from-nuke.mdFallout.Migrate.Analyzers/README.md—#sunset-timelinedeep linkThe analyzer
helpLinkUriis the one that mattered — it is the help link on theFALLOUTmigration diagnostic in consumers' IDEs, so a plain delete would have shipped a 404.The
Fallout.Migrate.Analyzers/README.mddeprecation note also lost its "ship through the 11.x line, remove in 12.0" plan, which predates the11.xline being skipped for calendar versioning (ADR-0004).Verification
grep -r rebrand-planover the tree — no remaining referencesFallout.Migrate.Analyzers.Specs14/14 passingNote
#581 also touches
docs/rebrand-plan.md(one plural→singular id fix) and itsFallout.Cli.csprojcomment originally pointed here — that pointer already moved to #582 in f7226b4. Whichever merges second just drops the file edit.🤖 Generated with Claude Code