Bump the release-branch prerelease counter to 10.4.0-rc.5 - #594
Merged
ChrisonSimtian merged 1 commit intoJul 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the release-branch prerelease counter from
10.4.0-rc.4to10.4.0-rc.5, so the next tag offrelease/v10.4ships the two queued cherry-picks.One-line change to
version.json.Why
On a release branch the prerelease number is a manual counter, not
{height}— see branching-and-release.md → Prerelease numbers on a release branch are a manual counter. Tagging without bumping republishes an existing version, anddotnet nuget push --skip-duplicateswallows that silently, so the packages just don't update.rc.5 is the first RC to carry:
Fallout.Common.ProjectModeltransition shim (fixes theCS0234/CS0246break consumers hit upgrading 10.3.x → rc.4).Fallout.GlobalTool, so GA continues the id the install base has pinned.Verification
dotnet pack src/Fallout.Clion this branch stamps10.4.0-rc.5. (Locally it also carries a.g<commit>suffix and the pre-#593 plural id, both only because this topic branch isn't a public release ref and doesn't include #593 — onrelease/v10.4with both cherry-picks in it stampsFallout.GlobalTool.10.4.0-rc.5.)Merge order
Independent of #590 and #593 — no file overlap, so all three can merge in any order. The only ordering that matters is the tag: cut
v10.4.0-rc.5only once all three are onrelease/v10.4, or the RC ships without the fixes it's numbered for.