[OoT] Fix include reading for DL imports#691
Merged
Merged
Conversation
Contributor
Author
|
Got two reports that this fix works |
Yanis002
approved these changes
Apr 15, 2026
Yanis002
added
the
merge soon
Collaborator
|
I forgot about this PR lol, thanks to everyone who tested it 🫡 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fast64 was not looking in extracted/VERSION/ for DL imports, causing e.g. imports of Link DLs like
gLinkAdultLeftHandHoldingMasterSwordNearDLto fail due to not finding eggHilite1Tex_WIDTHThe fix is to pass a list to
ootGetIncludedAssetDataasbasePathsinstead of the previously singularbasePathwhich basically corresponds to the repo include pathThis fix could be applied to other import things too (like anim and skeleton import) but it's not necessary at the moment so I'd rather not touch anything there :^)
I did not test this super thoroughly, I'm just assuming it didn't break anything