Use varhandle for array access in CBORGenerator - #752
Open
pjfanning wants to merge 8 commits into
Open
Conversation
🧪 Code Coverage Report
|
Added comments explaining the choice of float representation in _writeFloatNoCheck method.
Removed commented-out code regarding float handling.
cowtowncoder
changed the title
Member
|
@pjfanning Any chance for brief jmh perf verification? |
cowtowncoder
changed the title
CBORGenerator
Member
Author
|
@cowtowncoder I added a benchmark to https://github.com/pjfanning/double-reader-writer Got these results on my laptop (Java 25) cborBaselineWriteDoubleArray is current 3.x code |
pjfanning
changed the title
CBORGenerator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VarHandle path is a single store instruction on most JVMs, versus 8 separate shift-cast-store operations. The same utility could be shared with the Smile module if desired.
Fallback to existing code if var handles are not supported, eg Android.