Skip to content

Verify difference file path against DatabaseAccess #9089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
caolanm wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −0
Open

Verify difference file path against DatabaseAccess #9089

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/jrd/nbak.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
#include "lck.h"
#include "cch.h"
#include "lck.h"
#include "jrd_proto.h"
#include "pag_proto.h"
#include "err_proto.h"
#include "cch_proto.h"
Expand Down Expand Up @@ -223,6 +224,14 @@ void BackupManager::generateFilename()
void BackupManager::openDelta(thread_db* tdbb)
{
fb_assert(!diff_file);

// Verify difference file path against DatabaseAccess entry of firebird.conf
if (!JRD_verify_database_access(diff_name))
{
ERR_post(Arg::Gds(isc_conf_access_denied) << Arg::Str("difference file") <<
Arg::Str(diff_name));
}

diff_file = PIO_open(tdbb, diff_name, diff_name);
}

Expand Down Expand Up @@ -276,6 +285,14 @@ void BackupManager::beginBackup(thread_db* tdbb)
{
// Create file
NBAK_TRACE(("Creating difference file %s", diff_name.c_str()));

// Verify difference file path against DatabaseAccess entry of firebird.conf
if (!JRD_verify_database_access(diff_name))
{
ERR_post(Arg::Gds(isc_conf_access_denied) << Arg::Str("difference file") <<
Arg::Str(diff_name));
}

diff_file = PIO_create(tdbb, diff_name, true, false);
}
catch (const Firebird::Exception&)
Expand Down