Skip to content

feat: add CodeArts Agent skills support#1266

Merged
clay-good merged 7 commits into
Fission-AI:mainfrom
CodeArtsAgent:feat/codeartsagent-support
Jul 17, 2026
Merged

feat: add CodeArts Agent skills support#1266
clay-good merged 7 commits into
Fission-AI:mainfrom
CodeArtsAgent:feat/codeartsagent-support

Conversation

@CodeArtsAgent

@CodeArtsAgent CodeArtsAgent commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add CodeArts as a supported openspec init tool using the codeartsagent tool ID and .codeartsdoer skills directory.
  • Preserve adapterless skills-only behavior by skipping command generation when no CodeArts command adapter exists.
  • Update CLI/tool documentation and add coverage for init, detection, and command registry behavior.

Verification

  • npx vitest run test/core/init.test.ts -t \"CodeArts\"
  • npx vitest run test/core/available-tools.test.ts test/core/shared/tool-detection.test.ts test/core/command-generation/registry.test.ts
  • npm run lint (passes with existing warning in src/core/references.ts)
  • npm run build
  • Manual global package smoke test: openspec init --tools codeartsagent

Summary by CodeRabbit

  • New Features
    • Added CodeArts (codeartsagent) as a recognized AI tool, with skills-only support.
    • Ensures CodeArts uses skill-based /openspec-* invocations and does not generate opsx-* command files.
  • Documentation
    • Updated CLI/help, supported tool references, command syntax tables, and troubleshooting to include CodeArts and clarify adapterless behavior.
  • Tests
    • Expanded coverage for CodeArts detection and initialization, including verifying skill file creation and adapter/command directory omission.

@CodeArtsAgent
CodeArtsAgent requested a review from TabishB as a code owner June 26, 2026 10:01
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 55a8fcc6-cfd3-40b6-850d-e90c928f25e4

📥 Commits

Reviewing files that changed from the base of the PR and between 9097679 and 17cd192.

📒 Files selected for processing (1)
  • docs/cli.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs/cli.md

📝 Walkthrough

Walkthrough

This PR adds CodeArts (codeartsagent) as a supported skills-only AI tool, with detection and initialization coverage plus documentation for skill-based invocation and the absence of command-file adapters.

Changes

CodeArts tool support

Layer / File(s) Summary
Tool entry and detection
src/core/config.ts, test/core/available-tools.test.ts, test/core/shared/tool-detection.test.ts
AI_TOOLS gains CodeArts, with tests covering .codeartsdoer detection and configured skills-directory discovery.
Adapterless init and registry behavior
test/core/command-generation/registry.test.ts, test/core/init.test.ts
codeartsagent is covered as a skills-only tool without a command adapter, including skill creation, skipped commands, logging, and --tools all.
CodeArts docs and command syntax
docs/cli.md, docs/commands.md, docs/how-commands-work.md, docs/supported-tools.md, docs/troubleshooting.md
Documentation adds CodeArts to supported-tool lists, skill invocation references, and command-file troubleshooting guidance.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: tabishb

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding CodeArts Agent skills support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@test/core/init.test.ts`:
- Line 211: There is a duplicate const declaration for logCalls in the same test
block, which causes a block-scoped redeclaration error. In init.test.ts, keep
only one logCalls definition and remove the extra duplicate line near the
console.log mock usage so the test file compiles cleanly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 980dbd49-2ed6-43f8-81c5-88c369cc5574

📥 Commits

Reviewing files that changed from the base of the PR and between 737518b and 9b78b4b.

📒 Files selected for processing (10)
  • docs/cli.md
  • docs/commands.md
  • docs/how-commands-work.md
  • docs/supported-tools.md
  • docs/troubleshooting.md
  • src/core/config.ts
  • test/core/available-tools.test.ts
  • test/core/command-generation/registry.test.ts
  • test/core/init.test.ts
  • test/core/shared/tool-detection.test.ts

Comment thread test/core/init.test.ts

@alfred-openspec alfred-openspec left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the CodeArts Agent skills-only integration across config, init/update behavior, adapterless command handling, docs, and focused tests. Paths match the public CodeArts skills surface, command generation correctly stays skipped without an adapter, and the added coverage hits the right seams.\n\nOne minor existing UX nit: adapterless tools can still appear in the generic success count as if commands exist before the explicit skipped-commands line clarifies it. Not introduced here and not blocking.

CodeArtsAgent and others added 2 commits July 6, 2026 16:07
…pport

# Conflicts:
#	docs/cli.md
#	docs/commands.md
#	docs/how-commands-work.md
#	docs/supported-tools.md
#	docs/troubleshooting.md
#	test/core/available-tools.test.ts
#	test/core/init.test.ts

@alfred-openspec alfred-openspec left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the CodeArts path semantics against current Agent Skills support, plus adapterless registry, detection, init, and docs coverage. The rebase is clean and current CI is green.

Union resolutions with the hermes (Fission-AI#1292), zcode (Fission-AI#1209), and kimi-code
(Fission-AI#1208) merges: combined tool-ID list, both detection test groups, the
CodeArts assertion folded into the shared skills-only registry test, and
all adapterless init tests kept.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@clay-good

Copy link
Copy Markdown
Collaborator

Merged main into this branch (9097679), resolving conflicts with the hermes (#1292), zcode (#1209), and kimi-code (#1208) merges: unioned the tool-ID list, kept both detection test groups, folded the CodeArts assertion into the shared skills-only adapter test, and kept all adapterless init tests. Affected suites (332 tests) pass locally. @alfred-openspec please re-review.

@clay-good
clay-good enabled auto-merge July 17, 2026 21:05

@alfred-openspec alfred-openspec left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CodeArts code and test merge looks clean, but the touched docs/cli.md tool-ID list says it mirrors AI_TOOLS while still omitting the now-present hermes and zcode IDs from main. Please union those two IDs into this list so it matches both src/core/config.ts and the correctly resolved list in docs/supported-tools.md.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
test/core/init.test.ts (1)

266-266: 🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win

Remove duplicate logCalls declaration.

The variable logCalls is declared twice consecutively in the same block scope, which will cause a TS2451 compilation error. Please remove the duplicate declaration (this appears to be a regression from merge conflict resolution).

🐛 Proposed fix
-      const logCalls = (console.log as unknown as { mock: { calls: unknown[][] } }).mock.calls.flat().map(String);
       const logCalls = (console.log as unknown as { mock: { calls: unknown[][] } }).mock.calls.flat().map(String);
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@test/core/init.test.ts` at line 266, Remove the duplicate consecutive
logCalls declaration in the test block, retaining a single initialization from
console.log mock calls so the block compiles without a redeclaration error.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@test/core/init.test.ts`:
- Line 266: Remove the duplicate consecutive logCalls declaration in the test
block, retaining a single initialization from console.log mock calls so the
block compiles without a redeclaration error.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9bf4eef0-6a20-443a-8cc5-db905c21cc68

📥 Commits

Reviewing files that changed from the base of the PR and between f781f4a and 9097679.

📒 Files selected for processing (7)
  • docs/cli.md
  • docs/commands.md
  • docs/supported-tools.md
  • src/core/config.ts
  • test/core/available-tools.test.ts
  • test/core/command-generation/registry.test.ts
  • test/core/init.test.ts
🚧 Files skipped from review as they are similar to previous changes (4)
  • test/core/command-generation/registry.test.ts
  • docs/cli.md
  • src/core/config.ts
  • docs/commands.md

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@clay-good

Copy link
Copy Markdown
Collaborator

Fixed: docs/cli.md tool-ID list now includes hermes and zcode, matching src/core/config.ts and docs/supported-tools.md. @alfred-openspec please re-review.

@alfred-openspec alfred-openspec left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the remediation adds hermes and zcode to the touched CLI tool-ID list, restoring exact parity with AI_TOOLS and docs/supported-tools.md; no unrelated files changed. The CodeArts skills-only integration remains correctly scoped and all platform checks are green.

@clay-good
clay-good added this pull request to the merge queue Jul 17, 2026
Merged via the queue into Fission-AI:main with commit ac656c9 Jul 17, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants