feat: add CodeArts Agent skills support#1266
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR adds CodeArts ( ChangesCodeArts tool support
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/core/init.test.ts`:
- Line 211: There is a duplicate const declaration for logCalls in the same test
block, which causes a block-scoped redeclaration error. In init.test.ts, keep
only one logCalls definition and remove the extra duplicate line near the
console.log mock usage so the test file compiles cleanly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 980dbd49-2ed6-43f8-81c5-88c369cc5574
📒 Files selected for processing (10)
docs/cli.mddocs/commands.mddocs/how-commands-work.mddocs/supported-tools.mddocs/troubleshooting.mdsrc/core/config.tstest/core/available-tools.test.tstest/core/command-generation/registry.test.tstest/core/init.test.tstest/core/shared/tool-detection.test.ts
alfred-openspec
left a comment
There was a problem hiding this comment.
Reviewed the CodeArts Agent skills-only integration across config, init/update behavior, adapterless command handling, docs, and focused tests. Paths match the public CodeArts skills surface, command generation correctly stays skipped without an adapter, and the added coverage hits the right seams.\n\nOne minor existing UX nit: adapterless tools can still appear in the generic success count as if commands exist before the explicit skipped-commands line clarifies it. Not introduced here and not blocking.
…pport # Conflicts: # docs/cli.md # docs/commands.md # docs/how-commands-work.md # docs/supported-tools.md # docs/troubleshooting.md # test/core/available-tools.test.ts # test/core/init.test.ts
alfred-openspec
left a comment
There was a problem hiding this comment.
Verified the CodeArts path semantics against current Agent Skills support, plus adapterless registry, detection, init, and docs coverage. The rebase is clean and current CI is green.
Union resolutions with the hermes (Fission-AI#1292), zcode (Fission-AI#1209), and kimi-code (Fission-AI#1208) merges: combined tool-ID list, both detection test groups, the CodeArts assertion folded into the shared skills-only registry test, and all adapterless init tests kept. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Merged |
alfred-openspec
left a comment
There was a problem hiding this comment.
The CodeArts code and test merge looks clean, but the touched docs/cli.md tool-ID list says it mirrors AI_TOOLS while still omitting the now-present hermes and zcode IDs from main. Please union those two IDs into this list so it matches both src/core/config.ts and the correctly resolved list in docs/supported-tools.md.
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
test/core/init.test.ts (1)
266-266: 🎯 Functional Correctness | 🔴 Critical | ⚡ Quick winRemove duplicate
logCallsdeclaration.The variable
logCallsis declared twice consecutively in the same block scope, which will cause aTS2451compilation error. Please remove the duplicate declaration (this appears to be a regression from merge conflict resolution).🐛 Proposed fix
- const logCalls = (console.log as unknown as { mock: { calls: unknown[][] } }).mock.calls.flat().map(String); const logCalls = (console.log as unknown as { mock: { calls: unknown[][] } }).mock.calls.flat().map(String);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/core/init.test.ts` at line 266, Remove the duplicate consecutive logCalls declaration in the test block, retaining a single initialization from console.log mock calls so the block compiles without a redeclaration error.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@test/core/init.test.ts`:
- Line 266: Remove the duplicate consecutive logCalls declaration in the test
block, retaining a single initialization from console.log mock calls so the
block compiles without a redeclaration error.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 9bf4eef0-6a20-443a-8cc5-db905c21cc68
📒 Files selected for processing (7)
docs/cli.mddocs/commands.mddocs/supported-tools.mdsrc/core/config.tstest/core/available-tools.test.tstest/core/command-generation/registry.test.tstest/core/init.test.ts
🚧 Files skipped from review as they are similar to previous changes (4)
- test/core/command-generation/registry.test.ts
- docs/cli.md
- src/core/config.ts
- docs/commands.md
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Fixed: |
alfred-openspec
left a comment
There was a problem hiding this comment.
Verified the remediation adds hermes and zcode to the touched CLI tool-ID list, restoring exact parity with AI_TOOLS and docs/supported-tools.md; no unrelated files changed. The CodeArts skills-only integration remains correctly scoped and all platform checks are green.
Summary
openspec inittool using thecodeartsagenttool ID and.codeartsdoerskills directory.Verification
npx vitest run test/core/init.test.ts -t \"CodeArts\"npx vitest run test/core/available-tools.test.ts test/core/shared/tool-detection.test.ts test/core/command-generation/registry.test.tsnpm run lint(passes with existing warning insrc/core/references.ts)npm run buildopenspec init --tools codeartsagentSummary by CodeRabbit
codeartsagent) as a recognized AI tool, with skills-only support./openspec-*invocations and does not generateopsx-*command files.