feat(experiments): wire up results refresh with a shared RefreshControl#7857
Open
Zaimwa9 wants to merge 4 commits into
Open
feat(experiments): wire up results refresh with a shared RefreshControl#7857Zaimwa9 wants to merge 4 commits into
Zaimwa9 wants to merge 4 commits into
Conversation
- Extract generic RefreshControl (button + message slot + theme prop) into base/forms, replacing the exposures-only AsOfRefreshControl - Add ExperimentResultsRefreshControl with the full throttle/poll/view-state machine, surfaced as a primary button below the status button on the detail header - Convert refreshExperimentBayesianResults to a queryFn that reads Retry-After for 429 throttling parity with exposures - Add a RefreshControl Storybook story and resultsViewState unit tests - SCSS token hygiene: replace phantom --font-*-size custom properties in results.scss with literals (font-size is not tokenised); use the colorIconDanger token instead of a hardcoded #e53e3e
…ynchronous-yawning-star
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
github-actions
Bot
added
the
front-end
Contributor
Docker builds report
|
Contributor
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
|
Contributor
Visual Regression19 screenshots compared. See report for details. |
…p the load flash - Move the refresh control out of the detail header onto the Results heading line; use the default secondary (gray) theme instead of primary - Drop refetchOnMountOrArgChange from the control's bayesian-results query: the page already loads it, so the forced second fetch on mount re-animated the scorecards
github-actions
Bot
added
feature
github-actions
Bot
added
feature
…e lands Derive the button's refreshing state from the refreshRequested intent (set on click, cleared on completion or error) instead of the transient isSubmitting, so it no longer flickers out of the loading state in the gap between the 202 and the refetch confirming the refreshing view-state. Applies to both the results and exposures refresh controls.
github-actions
Bot
added
feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Refresh results" action was never wired up. This adds it as a primary button below the status button, at parity with exposures refresh.
AsOfRefreshControlinto a sharedbase/forms/RefreshControl(button + message slot +theme); adds a Storybook story.ExperimentResultsRefreshControl: 429/Retry-Afterthrottling, polling until recompute lands, view-state + final/availability gating. Converts the Bayesian refresh mutation to aqueryFnforRetry-After.--font-*-size→ literals;#e53e3e→colorIconDanger.How did you test this code?
resultsViewStateunit tests + existing results suites: 37/37 pass; lint + tsc clean.