feat: create segment sources fake door modal by Zaimwa9 · Pull Request #8272 · Flagsmith/flagsmith

Zaimwa9 · 2026-08-12T14:28:02Z

I have read the Contributing Guide.
I have added information to docs/ if required so people know about the feature.
I have filled in the "Changes" section below.
I have filled in the "How did you test this code" section below.

Changes

Adds a "Create Segment" choice modal offering segment sources, gated behind the create_segment_with_external_sources feature flag (flag off: the button opens the existing drawer directly, unchanged).

Manually — closes the modal and opens the existing rules drawer.
From a CSV list, Amplitude, Mixpanel, Adobe Journey Manager — fake doors carrying a Beta chip. Selecting one fires a segment_source_clicked SDK event (source, email, organisation metadata) and reveals a "Request access to the beta" button, which fires segment_source_beta_requested, disables itself, and thanks the user — same pattern as the Experiments fake door.

How did you test this code?

Manually, against staging:

Enable create_segment_with_external_sources for your organisation.
Segments → Create Segment: the choice modal opens; with the flag disabled the drawer opens directly.
Click "Manually" → modal closes, existing New Segment drawer opens.
Click each source → card highlights, segment_source_clicked fires with the right source.
Click "Request access to the beta" → segment_source_beta_requested fires, button disables with a thank-you message; selecting another source re-enables it.

vercel · 2026-08-12T14:28:09Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
flagsmith-frontend-preview	Ready	Preview	Aug 13, 2026 7:47am
flagsmith-frontend-staging	Ready	Preview	Aug 13, 2026 7:47am

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Ignored	Preview	Aug 13, 2026 7:47am

coderabbitai · 2026-08-12T14:28:25Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f2fd52c4-25dd-4bf4-abaa-e3343198dcd1

📥 Commits

Reviewing files that changed from the base of the PR and between b8410be and 0aede04.

📒 Files selected for processing (1)

frontend/web/components/icons/Icon.tsx

📝 Walkthrough

Walkthrough

Adds CreateSegmentSourcesModal with manual, CSV, Amplitude, Mixpanel, and Adobe Journey Manager options. The modal tracks source selection and beta-access requests through Flagsmith and prevents duplicate requests. SegmentsPage opens the modal when the feature flag is enabled and retains the existing drawer flow otherwise. Adds a wide modal style with an 860px maximum width.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Mergeability Score: ⚪ Minimal · up to 0aede

This localized frontend change adds a feature-flagged segment-source choice modal while preserving the existing flow when the flag is off; no actionable merge-blocking risk remains beyond normal checks and review.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-08-12T14:29:11Z

Docker builds report

Image	Build Status	Security report
`ghcr.io/flagsmith/flagsmith-api-test:pr-8272`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-e2e:pr-8272`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-api:pr-8272`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith:pr-8272`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-private-cloud:pr-8272`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-frontend:pr-8272`	Finished ✅	Results ✅

coderabbitai

Actionable comments posted: 3

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 49e7a95b-1adf-464f-ad0e-9991a9dd5936

📥 Commits

Reviewing files that changed from the base of the PR and between 6c88198 and fe9baf6.

📒 Files selected for processing (4)

frontend/web/components/modals/CreateSegmentSourcesModal/CreateSegmentSourcesModal.tsx
frontend/web/components/modals/CreateSegmentSourcesModal/index.ts
frontend/web/components/pages/SegmentsPage.tsx
frontend/web/styles/project/_modals.scss

github-actions · 2026-08-12T14:36:48Z

✅ private-cloud · depot-ubuntu-latest-16 — run #19284 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
54.5 seconds
0aede04
🔄 Run: #19284 (attempt 1)

🗂️ Previous results

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #19284 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

3 passed

Details

3 tests across 3 suites
59.8 seconds
0aede04
🔄 Run: #19284 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #19284 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

1 passed

Details

1 test across 1 suite
44.9 seconds
0aede04
🔄 Run: #19284 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #19284 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
32.7 seconds
0aede04
🔄 Run: #19284 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #19283 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

3 passed

Details

3 tests across 3 suites
55.2 seconds
b8410be
🔄 Run: #19283 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #19283 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

1 passed

Details

1 test across 1 suite
45.2 seconds
b8410be
🔄 Run: #19283 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #19283 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

23 passed
1 skipped

Details

24 tests across 18 suites
1 minute, 21 seconds
b8410be
🔄 Run: #19283 (attempt 1)

Skipped tests

firefox › tests/onboarding-tests.pw.ts › Onboarding › New user connects via the single-page onboarding flow @oss

✅ oss · depot-ubuntu-latest-16 — run #19283 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
41.2 seconds
b8410be
🔄 Run: #19283 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #19250 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
55.3 seconds
ddd6fe9
🔄 Run: #19250 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #19250 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

1 passed

Details

1 test across 1 suite
36.9 seconds
ddd6fe9
🔄 Run: #19250 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #19250 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

1 passed

Details

1 test across 1 suite
37.4 seconds
ddd6fe9
🔄 Run: #19250 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #19250 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
36.6 seconds
ddd6fe9
🔄 Run: #19250 (attempt 1)

github-actions · 2026-08-12T14:36:50Z

Visual Regression

19 screenshots compared. See report for details.
View full report

coderabbitai

Actionable comments posted: 3

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 9fb342c0-98b5-4eac-b26f-fb17ad913749

📥 Commits

Reviewing files that changed from the base of the PR and between fe9baf6 and ddd6fe9.

📒 Files selected for processing (3)

frontend/e2e/helpers/e2e-helpers.playwright.ts
frontend/web/components/modals/CreateSegmentSourcesModal/CreateSegmentSourcesModal.scss
frontend/web/components/modals/CreateSegmentSourcesModal/CreateSegmentSourcesModal.tsx

talissoncosta

Looks pretty good! Congrats! Just a few suggestions. I don't wanna block you. However it would be nice to keep it clean and reuse the existing components.

coderabbitai

Actionable comments posted: 1

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7c36ae63-a84d-44b7-b124-c65e413ff82c

📥 Commits

Reviewing files that changed from the base of the PR and between ddd6fe9 and b8410be.

📒 Files selected for processing (3)

frontend/web/components/icons/Icon.tsx
frontend/web/components/modals/CreateSegmentSourcesModal/CreateSegmentSourcesModal.scss
frontend/web/components/modals/CreateSegmentSourcesModal/CreateSegmentSourcesModal.tsx

Zaimwa9 requested a review from a team as a code owner August 12, 2026 14:28

Zaimwa9 requested review from talissoncosta and removed request for a team August 12, 2026 14:28

vercel Bot deployed to Preview – flagsmith-frontend-staging August 12, 2026 14:28 View deployment

vercel Bot deployed to Preview – flagsmith-frontend-preview August 12, 2026 14:28 View deployment

github-actions Bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels Aug 12, 2026

coderabbitai Bot reviewed Aug 12, 2026

View reviewed changes

Zaimwa9 force-pushed the feat/create-segment-sources-fake-door branch from fe9baf6 to ddd6fe9 Compare August 12, 2026 14:48

vercel Bot deployed to Preview – flagsmith-frontend-staging August 12, 2026 14:49 View deployment

vercel Bot deployed to Preview – flagsmith-frontend-preview August 12, 2026 14:49 View deployment

github-actions Bot added feature New feature or request and removed feature New feature or request labels Aug 12, 2026

coderabbitai Bot reviewed Aug 12, 2026

View reviewed changes

talissoncosta previously approved these changes Aug 12, 2026

View reviewed changes

Zaimwa9 dismissed talissoncosta’s stale review via b8410be August 13, 2026 07:38

Zaimwa9 force-pushed the feat/create-segment-sources-fake-door branch from ddd6fe9 to b8410be Compare August 13, 2026 07:38

vercel Bot deployed to Preview – flagsmith-frontend-preview August 13, 2026 07:39 View deployment

vercel Bot deployed to Preview – flagsmith-frontend-staging August 13, 2026 07:39 View deployment

github-actions Bot added feature New feature or request and removed feature New feature or request labels Aug 13, 2026

coderabbitai Bot reviewed Aug 13, 2026

View reviewed changes

Comment thread frontend/web/components/icons/Icon.tsx

feat: create segment sources fake door modal

0aede04

Zaimwa9 force-pushed the feat/create-segment-sources-fake-door branch from b8410be to 0aede04 Compare August 13, 2026 07:46

vercel Bot deployed to Preview – flagsmith-frontend-staging August 13, 2026 07:47 View deployment

vercel Bot deployed to Preview – flagsmith-frontend-preview August 13, 2026 07:47 View deployment

github-actions Bot added feature New feature or request and removed feature New feature or request labels Aug 13, 2026

gagantrivedi approved these changes Aug 13, 2026

View reviewed changes

Zaimwa9 merged commit dc99d65 into main Aug 13, 2026
30 checks passed

Zaimwa9 deleted the feat/create-segment-sources-fake-door branch August 13, 2026 08:20

flagsmith-engineering Bot mentioned this pull request Aug 13, 2026

chore(main): release 2.263.0 #8267

Open

Uh oh!

Conversation

Zaimwa9 commented Aug 12, 2026

Changes

How did you test this code?

Uh oh!

vercel Bot commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

github-actions Bot commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Docker builds report

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Uh oh!

github-actions Bot commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Visual Regression

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

talissoncosta left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

vercel Bot commented Aug 12, 2026 •

edited

Loading

coderabbitai Bot commented Aug 12, 2026 •

edited

Loading

github-actions Bot commented Aug 12, 2026 •

edited

Loading

github-actions Bot commented Aug 12, 2026 •

edited

Loading

github-actions Bot commented Aug 12, 2026 •

edited

Loading

talissoncosta left a comment •

edited

Loading