Skip to content

fix(onboarding): run the tour in the project you just created - #8277

Open
talissoncosta wants to merge 1 commit into
fix/onboarding-skip-flag-creation-existing-projectfrom
fix/onboarding-project-selection
Open

fix(onboarding): run the tour in the project you just created#8277
talissoncosta wants to merge 1 commit into
fix/onboarding-skip-flag-creation-existing-projectfrom
fix/onboarding-project-selection

Conversation

@talissoncosta

@talissoncosta talissoncosta commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Stacked on #8217, which decides whether a project may be toured. This decides which project we look at.

  • ensureProject took whichever project the API returned first, so onboarding couldn't be re-run by creating a project, and an empty first project got seeded instead. Now it takes the newest.

Still open: if that newest project is a colleague's and still empty, it's still seeded. Telling that apart needs a persisted "has onboarded" flag on the user.

How did you test this code?

  • 3 unit tests on the rule, checked by mutation
  • test:unit (407) and lint clean, no typecheck errors in the touched files
  • Existing account, new empty project: tour runs there rather than in the first project
  • New account: unchanged, project created and tour runs
  • Mid-tour refresh: still resumes

@talissoncosta
talissoncosta requested a review from a team as a code owner August 12, 2026 18:55
@talissoncosta
talissoncosta requested review from kyle-ssg and removed request for a team August 12, 2026 18:55
@vercel

vercel Bot commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview Aug 12, 2026 8:12pm
flagsmith-frontend-staging Ready Ready Preview Aug 12, 2026 8:12pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Aug 12, 2026 8:12pm

Request Review

@coderabbitai

coderabbitai Bot commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 444b23bc-f71b-4ae6-a5f8-e75133c57931

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added front-end Issue related to the React Front End Dashboard fix labels Aug 12, 2026
@github-actions

github-actions Bot commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-8277 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-8277 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith:pr-8277 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-8277 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-8277 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-8277 Finished ✅ Results ✅

@github-actions

github-actions Bot commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #19273 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 3 seconds
commit  5e15af2
info  🔄 Run: #19273 (attempt 1)

🗂️ Previous results
✅ private-cloud · depot-ubuntu-latest-16 — run #19273 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 1 suite
duration  18.8 seconds
commit  5e15af2
info  🔄 Run: #19273 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #19273 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  46.2 seconds
commit  5e15af2
info  🔄 Run: #19273 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #19273 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  44.4 seconds
commit  5e15af2
info  🔄 Run: #19273 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #19269 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  60 seconds
commit  ff125a9
info  🔄 Run: #19269 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #19269 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  34.9 seconds
commit  ff125a9
info  🔄 Run: #19269 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #19269 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  44.9 seconds
commit  ff125a9
info  🔄 Run: #19269 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #19269 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  42.3 seconds
commit  ff125a9
info  🔄 Run: #19269 (attempt 1)

@github-actions

github-actions Bot commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

@talissoncosta @claude
fix(onboarding): run onboarding on the newest project, not the first
5e15af2 
ensureProject took whichever project the API returned first, so a
returning user's tour could act on a project they never onboarded in, and
an empty one would be seeded with a flag that isn't theirs.

Take the newest project instead. Creating a project and clicking Getting
Started is how you run onboarding again, and #8217's rule still decides
whether that project may be toured at all.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@talissoncosta
talissoncosta force-pushed the fix/onboarding-project-selection branch from ff125a9 to 5e15af2 Compare August 12, 2026 20:11
@talissoncosta talissoncosta changed the title fix(onboarding): don't tour a project we can't identify fix(onboarding): run onboarding on the newest project, not the first Aug 12, 2026
@github-actions github-actions Bot added fix and removed fix labels Aug 12, 2026
@talissoncosta
talissoncosta requested a review from Zaimwa9 August 12, 2026 20:16
@talissoncosta talissoncosta changed the title fix(onboarding): run onboarding on the newest project, not the first fix(onboarding): run the tour in the project you just created Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kyle-ssg kyle-ssg Awaiting requested review from kyle-ssg kyle-ssg is a code owner automatically assigned from Flagsmith/flagsmith-front-end
@Zaimwa9 Zaimwa9 Awaiting requested review from Zaimwa9

Assignees

No one assigned

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@talissoncosta