Avoid integer overflow when symmetrizing ellipse matrices - #5239
Open
FlorianPfaff wants to merge 3 commits into
Open
Avoid integer overflow when symmetrizing ellipse matrices#5239FlorianPfaff wants to merge 3 commits into
FlorianPfaff wants to merge 3 commits into
Conversation
FlorianPfaff
enabled auto-merge (squash)
August 6, 2026 06:12
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
tracking.ellipse_geometry.symmetrizeBug
The previous implementation evaluated
matrix + matrix.Tin the input integer dtype and only multiplied by0.5afterward. For example,should symmetrize to
[[120, 90], [90, 110]], but the intermediate integer addition overflowed and produced[[-8, -38], [-38, -18]].This affects public calls such as
project_symmetric_covariance()when users provide integer array-like covariance input.Fix
Use
which preserves the mathematical result for floating-point inputs while promoting integer operands before addition.
Testing
Added
tests/tracking/test_ellipse_geometry_integer_overflow.py, which passes anint8covariance throughproject_symmetric_covariance()and checks both the correct numerical result and floating-point output dtype.