Stabilize tensor-train relative truncation - #5249
Closed
FlorianPfaff wants to merge 5 commits into
Closed
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
FlorianPfaff
marked this pull request as ready for review
August 6, 2026 10:13
Owner
Author
|
Superseded by #5251, which reapplies the same focused tensor-train fix directly onto current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bug
TensorTrain.from_dense(...)computed the tensor Frobenius norm with an unscaled Euclidean norm, while_choose_rank(...)computed singular-value tail energies by squaring the raw singular values.For large but finite tensors, those intermediate squares overflow even when the tensor entries, singular values, requested relative tolerance, and correct decomposition are all finite. A diagonal
2 x 2tensor with entries1e200raises under strict NumPy overflow handling; without strict handling, the infinite tolerance can incorrectly collapse the decomposition to rank one.Fix
max_rankbehavior.Regression coverage
Add a focused tensor-train regression using
diag(1e200, 1e200)undernp.errstate(over="raise", invalid="raise"). The decomposition must retain TT ranks(1, 2, 1)and reconstruct the finite input after scale normalization.Validation
sqrt(2) * 1e200and selects rank two;