Installed node settings hook - #7880
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## cache-catalogue-versions #7880 +/- ##
============================================================
- Coverage 75.55% 75.54% -0.01%
============================================================
Files 434 436 +2
Lines 23064 23096 +32
Branches 6112 6115 +3
============================================================
+ Hits 17425 17447 +22
- Misses 5639 5649 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I see I was tagged as reviewer for this but Is it ready for review Ben? Just from a very quick glance I see things like swallowed errors ( note also, I believe you might need to drop the association for device and switch to application logic as we have done for things like access_token (casting from int to string for the device.id/ownerId will likely fail for PG) - but in saying that I see existing tests did not fail |
Yes all intentional, especially the devices as we have no way to gather that information as it is not shared. The current table is built that way to make it work if/when it ever is available. The errors get dropped because this is a async hook fired in the background and the only possible errors are back end db so failing to update is a small problem |
|
@Steve-Mcl The AccessTokens still has |
…e/flowfuse into cache-catalogue-versions
…wFuse/flowfuse into installed-node-settings-hook
|
Something strange is going on with package flies and lint, I'm going to merge this down to the other PR so I only need to fix it once and it can all be reviewed as one |
Steve-Mcl
left a comment
There was a problem hiding this comment.
I have a some thoughts on the design...
-
Why we are not using the existing controller methods
getProjectModule? - but then I found your proposal in a grandparent issue #6756 commentextract dependences table from settings object into it's own table to make searching/comparing displaying quicker/eastier
Fair enough - a flat/normalised table could be useful to improve performance of bom operations
-
As there is only a single table, every row has a
latestVersionmeaning potentially hundreds/thousands of duplicates. I would prefer a separate table e.g.NodeREDPackageVersionswhere each row simply represents a single package - then a simple join with this tableNodeREDNodeVersionswould remove the need for a staticupdateAllLatestmethod.
However, this is not blocking and could be later retrod so I wont block.
fixes #7736
Description
Uses DB hooks to keep latest version of Node-RED nodes list up to date
This PR merges into #7772
Related Issue(s)
#7736
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel