fix(vectorstores): add missing base classes to DocStoreVector node#6491
fix(vectorstores): add missing base classes to DocStoreVector node#6491corporatepoetry wants to merge 1 commit into
Conversation
DocStore_VectorStores was the only vector store node missing 'VectorStoreRetriever' and 'BaseRetriever' in its baseClasses, preventing it from being connectable to nodes expecting those types. Also adds 'VectorStoreRetriever' to the retriever output baseClasses and bumps the node version to 1.1.
There was a problem hiding this comment.
Code Review
This pull request updates the DocStoreVector component by incrementing its version to 1.1 and expanding the baseClasses for both the node and its retriever input to include VectorStoreRetriever and BaseRetriever. The reviewer suggested also adding VectorStore to the node's top-level baseClasses to ensure full compatibility and connectability as a vector store.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| this.category = 'Vector Stores' | ||
| this.description = `Search and retrieve documents from Document Store` | ||
| this.baseClasses = [this.type] | ||
| this.baseClasses = [this.type, 'VectorStoreRetriever', 'BaseRetriever'] |
There was a problem hiding this comment.
Since this node can also output a VectorStore (as defined in the outputs array), it should include 'VectorStore' in its top-level baseClasses to ensure it is fully compatible and connectable as a vector store in all contexts.
| this.baseClasses = [this.type, 'VectorStoreRetriever', 'BaseRetriever'] | |
| this.baseClasses = [this.type, 'VectorStore', 'VectorStoreRetriever', 'BaseRetriever'] |
DocStore_VectorStores was the only vector store node missing 'VectorStoreRetriever' and 'BaseRetriever' in its baseClasses, preventing it from being connectable to nodes expecting those types.
Also adds 'VectorStoreRetriever' to the retriever output baseClasses and bumps the node version to 1.1.
Fixes #6490