Skip to content

fix(vectorstores): add missing base classes to DocStoreVector node#6491

Open
corporatepoetry wants to merge 1 commit into
FlowiseAI:mainfrom
corporatepoetry:bugfix/docstore-vectorstore-output-typing
Open

fix(vectorstores): add missing base classes to DocStoreVector node#6491
corporatepoetry wants to merge 1 commit into
FlowiseAI:mainfrom
corporatepoetry:bugfix/docstore-vectorstore-output-typing

Conversation

@corporatepoetry

Copy link
Copy Markdown

DocStore_VectorStores was the only vector store node missing 'VectorStoreRetriever' and 'BaseRetriever' in its baseClasses, preventing it from being connectable to nodes expecting those types.

Also adds 'VectorStoreRetriever' to the retriever output baseClasses and bumps the node version to 1.1.

Fixes #6490

DocStore_VectorStores was the only vector store node missing
'VectorStoreRetriever' and 'BaseRetriever' in its baseClasses,
preventing it from being connectable to nodes expecting those types.

Also adds 'VectorStoreRetriever' to the retriever output baseClasses
and bumps the node version to 1.1.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the DocStoreVector component by incrementing its version to 1.1 and expanding the baseClasses for both the node and its retriever input to include VectorStoreRetriever and BaseRetriever. The reviewer suggested also adding VectorStore to the node's top-level baseClasses to ensure full compatibility and connectability as a vector store.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

this.category = 'Vector Stores'
this.description = `Search and retrieve documents from Document Store`
this.baseClasses = [this.type]
this.baseClasses = [this.type, 'VectorStoreRetriever', 'BaseRetriever']

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since this node can also output a VectorStore (as defined in the outputs array), it should include 'VectorStore' in its top-level baseClasses to ensure it is fully compatible and connectable as a vector store in all contexts.

Suggested change
this.baseClasses = [this.type, 'VectorStoreRetriever', 'BaseRetriever']
this.baseClasses = [this.type, 'VectorStore', 'VectorStoreRetriever', 'BaseRetriever']

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to wire Document Store (Vector) output to Rerank Retriever nodes' Vector Store Retriever input

1 participant