fix: apply min/max modifiers to ZodNumber in secureZodParser - #6672
Open
Osamaali313 wants to merge 1 commit into
Open
fix: apply min/max modifiers to ZodNumber in secureZodParser#6672Osamaali313 wants to merge 1 commit into
Osamaali313 wants to merge 1 commit into
Conversation
applyModifiers handled .min()/.max() for ZodString and ZodArray but not ZodNumber, so numeric bounds in a user schema (e.g. z.number().min(0).max(100)) were silently discarded and out-of-range values passed validation. The sibling `int` case already branches on ZodNumber, confirming numeric modifiers are meant to apply. Add the missing ZodNumber branch to both min and max.
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SecureZodSchemaParser.applyModifiers(packages/components/src/secureZodParser.ts) applies.min()/.max()forZodStringandZodArray, but has noZodNumberbranch — so numeric bounds are silently dropped:A user schema like
z.number().min(0).max(100)therefore accepts out-of-range values (e.g.999,-50). This parser is used by the Structured Output Parser (Advanced) and Custom Tool nodes, so LLM structured output / tool arguments that the author explicitly bounded are passed through unvalidated. The siblingintcase already branches onZodNumber, confirming numeric modifiers are meant to apply.Repro (schema
z.object({ score: z.number().min(0).max(100) })): before,score: 999andscore: -50are accepted; after, they're rejected (too_big/too_small), while az.string().max(5)control already worked.Fix
Add the missing
ZodNumberbranch to bothminandmax:String/array bounds are unchanged. (There was no existing test file for
secureZodParser.ts; happy to add one if you'd like.)