Update github workflows to node 24

.github/workflows/release-linux.yml

@@ -13,9 +13,9 @@ jobs:
         steps:
             - uses: "actions/checkout@v5"
             - name: "Set Up Node"
-              uses: "actions/setup-node@v4"
+              uses: "actions/setup-node@v6"
               with:
-                  node-version: "22.x"
+                  node-version: "24.x"
                   cache: "npm"
             - run: "npm ci"
             - run: "npm run build"

.github/workflows/release-macos.yml

@@ -13,9 +13,9 @@ jobs:
         steps:
             - uses: "actions/checkout@v5"
             - name: "Set Up Node"
-              uses: "actions/setup-node@v4"
+              uses: "actions/setup-node@v6"
               with:
-                  node-version: "22.x"
+                  node-version: "24.x"
                   cache: "npm"
             - run: "npm ci"
             - run: "npm run build"

.github/workflows/release-windows.yml

@@ -13,9 +13,9 @@ jobs:
         steps:
             - uses: "actions/checkout@v5"
             - name: "Set Up Node"
-              uses: "actions/setup-node@v4"
+              uses: "actions/setup-node@v6"
               with:
-                  node-version: "22.x"
+                  node-version: "24.x"
                   cache: "npm"
             - run: "npm ci"
             - run: "npm run build"

.github/workflows/test-linux.yml

@@ -11,9 +11,9 @@ jobs:
         steps:
             - uses: "actions/checkout@v5"
             - name: "Set Up Node"
-              uses: "actions/setup-node@v4"
+              uses: "actions/setup-node@v6"
               with:
-                  node-version: "22.x"
+                  node-version: "24.x"
                   cache: "npm"
             - run: "npm ci"
             - run: "npm run build"
@@ -24,9 +24,9 @@ jobs:
         steps:
             - uses: "actions/checkout@v5"
             - name: "Build Debian Package"
-              uses: "actions/setup-node@v4"
+              uses: "actions/setup-node@v6"
               with:
-                  node-version: "22.x"
+                  node-version: "24.x"
                   cache: "npm"
             - run: "npm ci"
             - run: "npm run build"

.github/workflows/test-macos.yml

@@ -11,9 +11,9 @@ jobs:
         steps:
             - uses: "actions/checkout@v5"
             - name: "Set Up Node"
-              uses: "actions/setup-node@v4"
+              uses: "actions/setup-node@v6"
               with:
-                  node-version: "22.x"
+                  node-version: "24.x"
                   cache: "npm"
             - run: "npm ci"
             - run: "npm run build"

.github/workflows/test-windows.yml

@@ -11,9 +11,9 @@ jobs:
         steps:
             - uses: "actions/checkout@v5"
             - name: "Set Up Node"
-              uses: "actions/setup-node@v4"
+              uses: "actions/setup-node@v6"
               with:
-                  node-version: "22.x"
+                  node-version: "24.x"
             - run: "npm ci"
             - run: "npm run build"
             - run: "npm run test"

src/main/pure-utils.ts

@@ -0,0 +1,25 @@
+/** Ensure we don't have too long of a message. */
+export function trimContent(
+    s: string,
+    charLen: number = 512,
+    lineLen: number = 5,
+): string {
+    return limitLines(trimString(s, charLen), lineLen);
+}
+
+function limitLines(s: string, maxLength: number): string {
+    const splitLines = s.split("\n");
+    if (splitLines.length <= maxLength) {
+        return s;
+    }
+    const newLines = splitLines.slice(0, maxLength - 1);
+    newLines.push("…more lines…");
+    return newLines.join("\n");
+}
+
+export function trimString(s: string, maxLength: number): string {
+    if (s.length <= maxLength) {
+        return s;
+    }
+    return s.substring(0, maxLength - 1) + "…";
+}

src/main/utils.ts

@@ -7,8 +7,9 @@ import {
     clipboard,
     systemPreferences,
 } from "electron";
-import { version } from "../../package.json";
+import pkg from "../../package.json";
 import { WindowManager } from "./window";
+import { trimContent, trimString } from "./pure-utils";
 import { promises, writeFile } from "fs";
 import { ImageCallbackTypes, TouchBarTexts } from "../schema-types";
 import { initMainTouchBar } from "./touchbar";
@@ -50,7 +51,7 @@ export function setUtilsListeners(manager: WindowManager) {
     });
 
     ipcMain.on("get-version", (event) => {
-        event.returnValue = version;
+        event.returnValue = pkg.version;
     });
 
     ipcMain.handle("open-external", (_, url: string, background: boolean) => {
@@ -336,35 +337,3 @@ export function setUtilsListeners(manager: WindowManager) {
         event.returnValue = manager.args;
     });
 }
-
-/** Ensure we don't have too long of a message. */
-function trimContent(
-    s: string,
-    charLen: number = 512,
-    lineLen: number = 5,
-): string {
-    return limitLines(trimString(s, charLen), lineLen);
-}
-
-function limitLines(s: string, maxLength: number): string {
-    const splitLines = s.split("\n");
-    if (splitLines.length <= maxLength) {
-        return s;
-    }
-    const newLines = splitLines.slice(0, maxLength - 1);
-    newLines.push("…more lines…");
-    return newLines.join("\n");
-}
-
-function trimString(s: string, maxLength: number): string {
-    if (s.length <= maxLength) {
-        return s;
-    }
-    return s.substring(0, maxLength - 1) + "…";
-}
-
-export const exportedForTesting = {
-    trimContent: trimContent,
-    limitLines: limitLines,
-    trimString: trimString,
-};

tests/main/test_pure-utils.ts

@@ -0,0 +1,13 @@
+import { expect } from "chai";
+import { trimContent } from "../../src/main/pure-utils";
+
+describe("dialog trimming", () => {
+    it("trims long words", () => {
+        expect(trimContent("M".repeat(1000))).to.equal("M".repeat(511) + "…");
+    });
+    it("trims too many lines", () => {
+        expect(trimContent("M\n".repeat(10))).to.equal(
+            "M\n".repeat(4) + "…more lines…",
+        );
+    });
+});