Skip to content

ci: use npm pack --dry-run for publishable packages#427

Merged
tomusdrw merged 2 commits into
mainfrom
td-fix-dry-run-publish
May 13, 2026
Merged

ci: use npm pack --dry-run for publishable packages#427
tomusdrw merged 2 commits into
mainfrom
td-fix-dry-run-publish

Conversation

@tomusdrw
Copy link
Copy Markdown
Member

@tomusdrw tomusdrw commented May 10, 2026

Summary

  • npm publish --dry-run still hits the npm registry and refuses if the current version already exists, so the PR-time check kept failing on links-metadata@1.4.0 (see run 24570858567).
  • Switched the PR job to npm pack --dry-run, which validates packaging (file list, prepack hooks, tarball) without contacting the registry. The real publish.yml job is unchanged and still enforces version uniqueness at release time.

Test plan

  • Node.js CI passes on this PR (no more "cannot publish over previously published versions" error).

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated continuous integration workflow for improved package verification.

Review Change Stack

`npm publish --dry-run` still hits the registry and fails when the
current version already exists. Switching to `npm pack --dry-run`
validates packaging without the registry check, so the PR job no
longer blocks on already-published versions.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented May 10, 2026

Deploy Preview for graypaper-reader ready!

Name Link
🔨 Latest commit 30f256b
🔍 Latest deploy log https://app.netlify.com/projects/graypaper-reader/deploys/6a010720565c0d0008fa6dbb
😎 Deploy Preview https://deploy-preview-427--graypaper-reader.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 10, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (5)
  • tools/snapshot-tests/tests/split-screen.spec.ts-snapshots/split-header-version-dropdown-dark-mode-linux.png is excluded by !**/*.png
  • tools/snapshot-tests/tests/split-screen.spec.ts-snapshots/split-sidebar-overlay-closed-dark-mode-linux.png is excluded by !**/*.png
  • tools/snapshot-tests/tests/split-screen.spec.ts-snapshots/split-view-closed-dark-mode-linux.png is excluded by !**/*.png
  • tools/snapshot-tests/tests/split-screen.spec.ts-snapshots/split-view-opened-light-mode-linux.png is excluded by !**/*.png
  • tools/snapshot-tests/tests/split-screen.spec.ts-snapshots/split-view-via-url-light-mode-linux.png is excluded by !**/*.png

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b0c4f927-e3aa-4fcb-b4fc-c879b68cdb9e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The CI workflow for Node.js changes the package validation step from running npm publish --dry-run to npm pack --dry-run for the shared/links-metadata and tools/links-check workspaces, maintaining all other job steps unchanged.

Changes

CI Workflow Dry-run Package Step

Layer / File(s) Summary
Dry-run pack step
.github/workflows/node.js.yml
The "Dry-run publish" step is renamed to "Dry-run pack"; command changes from npm publish --dry-run to npm pack --dry-run for two workspaces.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

A rabbit hops through workflows bright,
Trading publish for pack with delight,
No publish today, just archives we'll test,
📦✨ Dry-run validation at its best!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: replacing npm publish --dry-run with npm pack --dry-run for publishable packages in the CI workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch td-fix-dry-run-publish

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

Visual Regression Test Report ✅ Passed

Github run id: 25641466988

🔗 Artifacts: Download

@tomusdrw tomusdrw merged commit d2412d4 into main May 13, 2026
5 checks passed
@tomusdrw tomusdrw deleted the td-fix-dry-run-publish branch May 13, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant