SDKS-5026: Device Authorization Grant Feature Testing#202
Open
vibhorgoswami wants to merge 3 commits into
Open
SDKS-5026: Device Authorization Grant Feature Testing#202vibhorgoswami wants to merge 3 commits into
vibhorgoswami wants to merge 3 commits into
Conversation
Contributor
|
PR changed again? Review this PR in Change Stack to compare snapshots and stay oriented. Warning Review limit reached
More reviews will be available in 40 minutes and 9 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a Device Authorization Grant flow to the sample app: ZXing dependency, device-auth SDK client and config, activation UI with QR and approval sheet, navigation for approval paths, token/userprofile/logout wiring, and Env UI for configuring device-auth presets/customs. ChangesDevice Authorization Grant Feature
Estimated code review effort 🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
vibhorgoswami
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #202 +/- ##
=============================================
+ Coverage 44.42% 44.44% +0.02%
Complexity 1393 1393
=============================================
Files 315 315
Lines 9623 9623
Branches 1474 1474
=============================================
+ Hits 4275 4277 +2
Misses 4784 4784
+ Partials 564 562 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vibhorgoswami
temporarily deployed
to
github-pages
GitHub Actions
Inactive
vibhorgoswami
force-pushed
the
SDKS-5026
branch
2 times, most recently
from
d6c9a7b to
bb07373
Compare
vibhorgoswami
temporarily deployed
to
github-pages
GitHub Actions
Inactive
vibhorgoswami
temporarily deployed
to
github-pages
GitHub Actions
Inactive
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 7
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/config/EnvViewModel.kt (1)
346-364:⚠️ Potential issue | 🟠 Major | ⚡ Quick winInitialize Device Auth client during ViewModel bootstrap
daAppliedis loaded and assigned (Line 360), but no SDK instance is built in the same init path. This can leaveoidcDeviceClientout of sync with applied config until a manual selection happens.Suggested fix
withContext(Dispatchers.Main) { customJourneyConfigs = jCustom customDaVinciConfigs = dvCustom customWebConfigs = wCustom customDeviceAuthConfigs = daCustom appliedJourneyConfig = jApplied appliedDaVinciConfig = dvApplied appliedWebConfig = wApplied appliedDeviceAuthConfig = daApplied buildJourneyInstance(jApplied) buildDaVinciInstance(dvApplied) buildWebInstance(wApplied) + buildDeviceAuthClient(daApplied) }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/config/EnvViewModel.kt` around lines 346 - 364, The device auth applied config is loaded into appliedDeviceAuthConfig but the SDK client isn't initialized during ViewModel bootstrap; call the method that builds the Device Auth SDK instance (e.g., buildDeviceAuthInstance) with daApplied inside the same withContext block after setting appliedDeviceAuthConfig so oidcDeviceClient is initialized and stays in sync with the applied config.
🧹 Nitpick comments (1)
samples/pingsampleapp/src/main/res/values/strings.xml (1)
25-26: 💤 Low valueConsider using consistent terminology in title and subtitle.
The title uses the full term "Device Authorization Grant" while the subtitle abbreviates to "Device Auth". For improved clarity and consistency, consider using the full term in the subtitle as well.
📝 Suggested refinement
- <string name="text_device_authorization_grant_subtitle">Start or verify Device Auth</string> + <string name="text_device_authorization_grant_subtitle">Start or verify Device Authorization</string>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@samples/pingsampleapp/src/main/res/values/strings.xml` around lines 25 - 26, Update the subtitle string to use the full term to match the title: change the value of the resource named text_device_authorization_grant_subtitle so it reads "Start or verify Device Authorization Grant" (matching the wording of text_device_authorization_grant_title) to keep terminology consistent across the UI.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/authgrant/ApproveDeviceScreen.kt`:
- Around line 207-211: The onClick handler for the Approve with Browser Button
calls context.startActivity(Intent(Intent.ACTION_VIEW,
initialVerificationUri.toUri())) without guarding for ActivityNotFoundException;
wrap the launch in a safe check (use
context.packageManager?.resolveActivity(intent, 0) to ensure an app can handle
the intent or run startActivity inside a try/catch for
ActivityNotFoundException) and only call
onApproveWithBrowser(initialVerificationUri) after a successful launch; on
failure, log or show a user-facing message instead of dismissing UI so the flow
doesn't crash.
In
`@samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/authgrant/DeviceAuthorizationGrantViewModel.kt`:
- Around line 98-127: In the DeviceFlowStatus.Expired,
DeviceFlowStatus.AccessDenied and is DeviceFlowStatus.Failure branches update
the _uiState to also clear any stale device-auth artifacts: set userCode = ""
(or null if your UI state uses nullable), verificationUri = "" (or null), and
isSuccess = false along with the existing
hasStarted/statusMessage/errorMessage/isLoading changes so previous codes/URIs
and success flags are not retained after terminal error states; modify the calls
to _uiState.update in those branches (the ones shown handling Expired,
AccessDenied and Failure) to include these fields.
In
`@samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/config/EnvViewModel.kt`:
- Around line 470-472: The code compares appliedDeviceAuthConfig.display to
deleted.display and then injects a hard-coded DeviceAuthConfigState; instead,
compare a stable identifier (e.g., appliedDeviceAuthConfig.id or
appliedDeviceAuthConfig.issuer) to deleted.id/issuer and reuse an existing
preset from your presets list before falling back; update the branch around
appliedDeviceAuthConfig, deleted and selectDeviceAuthConfig to search your
presets for a matching config (by id or issuer) and call
selectDeviceAuthConfig(matchingPreset) if found, otherwise clear the selection
or select a safe default from presets rather than instantiating a new hard-coded
DeviceAuthConfigState.
In
`@samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/logout/Logout.kt`:
- Around line 159-173: The aggregate session predicates that drive the “Logout
All” enabled state and the “No Active Sessions” message do not include the
device-auth session (state.oidcDeviceClient); update the aggregate checks (the
functions/expressions that compute whether any session is active and whether
“logout all” should be enabled—e.g., the code in the composable/logic that reads
state.oidcUserSession, state.oidcBackchannel, state.samlSession, etc.) to also
consider state.oidcDeviceClient, and ensure the same updated predicate is used
where the “No Active Sessions” label and the Logout All button enabled/disabled
logic are computed (update the related ViewModel/composable methods such as
listLogoutOptions(), the logout-all handler predicate, and the UI
visibility/enablement checks to include oidcDeviceClient).
In
`@samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/logout/LogoutViewModel.kt`:
- Around line 62-67: Wrap the logout calls in try/catch/finally so failures
don't prevent onCompleted() or subsequent logouts: in logoutOidcDeviceClient,
call oidcDeviceClient?.user()?.logout() inside a try block, log or handle the
exception in catch, and call onCompleted() in finally; do the same pattern for
the other logout helpers referenced in this file (e.g., the logoutAll sequence
and any methods around lines 69-77) so each logout is resilient and errors don't
stop later calls.
In
`@samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/token/Token.kt`:
- Around line 115-122: The Tab composable currently hardcodes the label "Auth
Grant" (seen where Tab is created with selected = tokenState.selectedTab ==
TokenType.AUTH_GRANT and onClick calling
tokenViewModel.selectTab(TokenType.AUTH_GRANT) /
tokenViewModel.loadAllTokens()); extract this and other user-facing strings in
the Token composable (also around lines 153-206) into resources by adding
entries like auth_grant, access_token, clear, refresh, revoke to strings.xml and
replace hardcoded Text("Auth Grant") (and other hardcoded Text(...) usages) with
Text(stringResource(R.string.<name>)) to enable i18n consistency.
In
`@samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/userprofile/UserProfileViewModel.kt`:
- Around line 180-196: In authGrantUserInfo, when oidcDeviceClient?.user() is
null the function currently returns without clearing previous values; update the
logic in authGrantUserInfo to call state.update and set authGrantUser = null and
authGrantError = null (or appropriate cleared values) when
oidcDeviceClient?.user() returns null so stale profile data is removed; locate
this in the authGrantUserInfo function and ensure both the null-branch and
existing Result.Failure/Result.Success branches consistently update state via
state.update.
---
Outside diff comments:
In
`@samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/config/EnvViewModel.kt`:
- Around line 346-364: The device auth applied config is loaded into
appliedDeviceAuthConfig but the SDK client isn't initialized during ViewModel
bootstrap; call the method that builds the Device Auth SDK instance (e.g.,
buildDeviceAuthInstance) with daApplied inside the same withContext block after
setting appliedDeviceAuthConfig so oidcDeviceClient is initialized and stays in
sync with the applied config.
---
Nitpick comments:
In `@samples/pingsampleapp/src/main/res/values/strings.xml`:
- Around line 25-26: Update the subtitle string to use the full term to match
the title: change the value of the resource named
text_device_authorization_grant_subtitle so it reads "Start or verify Device
Authorization Grant" (matching the wording of
text_device_authorization_grant_title) to keep terminology consistent across the
UI.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 12e2be9e-a913-490c-b230-974b82dd3767
📒 Files selected for processing (19)
gradle/libs.versions.tomlsamples/pingsampleapp/build.gradle.ktssamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/authgrant/ApproveDeviceScreen.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/authgrant/DeviceAuthorizationGrantScreen.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/authgrant/DeviceAuthorizationGrantViewModel.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/config/Env.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/config/EnvViewModel.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/davinci/DaVinci.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/davinci/DaVinciViewModel.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/home/HomeApp.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/logout/Logout.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/logout/LogoutViewModel.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/navigation/Navigation.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/token/Token.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/token/TokenState.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/token/TokenViewModel.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/userprofile/UserProfile.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/userprofile/UserProfileViewModel.ktsamples/pingsampleapp/src/main/res/values/strings.xml
Comment on lines
+115
to
+122
| Tab( | ||
| selected = tokenState.selectedTab == TokenType.AUTH_GRANT, | ||
| onClick = { | ||
| tokenViewModel.selectTab(TokenType.AUTH_GRANT) | ||
| tokenViewModel.loadAllTokens() | ||
| }, | ||
| text = { Text("Auth Grant") } | ||
| ) |
Contributor
There was a problem hiding this comment.
Externalize new/edited UI labels to resources.
New/edited user-facing labels are hardcoded in the composable. Please move them to strings.xml and use stringResource(...) for i18n consistency.
Proposed fix
+import androidx.compose.ui.res.stringResource
@@
- text = { Text("Auth Grant") }
+ text = { Text(stringResource(R.string.auth_grant)) }
@@
- text = { Text("Refresh") },
+ text = { Text(stringResource(R.string.refresh)) },
@@
- text = { Text("Revoke") },
+ text = { Text(stringResource(R.string.revoke)) },
@@
- Text(text = "AccessToken")
+ Text(text = stringResource(R.string.access_token))
@@
- Text(text = "Clear")
+ Text(text = stringResource(R.string.clear))
@@
- Text(text = "Refresh")
+ Text(text = stringResource(R.string.refresh))
@@
- Text(text = "Revoke")
+ Text(text = stringResource(R.string.revoke))<!-- samples/pingsampleapp/src/main/res/values/strings.xml -->
<string name="auth_grant">Auth Grant</string>
<string name="access_token">Access token</string>
<string name="clear">Clear</string>
<string name="refresh">Refresh</string>
<string name="revoke">Revoke</string>Also applies to: 153-206
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/token/Token.kt`
around lines 115 - 122, The Tab composable currently hardcodes the label "Auth
Grant" (seen where Tab is created with selected = tokenState.selectedTab ==
TokenType.AUTH_GRANT and onClick calling
tokenViewModel.selectTab(TokenType.AUTH_GRANT) /
tokenViewModel.loadAllTokens()); extract this and other user-facing strings in
the Token composable (also around lines 153-206) into resources by adding
entries like auth_grant, access_token, clear, refresh, revoke to strings.xml and
replace hardcoded Text("Auth Grant") (and other hardcoded Text(...) usages) with
Text(stringResource(R.string.<name>)) to enable i18n consistency.
vibhorgoswami
temporarily deployed
to
github-pages
GitHub Actions
Inactive
witrisna
force-pushed
the
SDKS-4784
branch
2 times, most recently
from
14b1925 to
f8980b3
Compare
vibhorgoswami
temporarily deployed
to
github-pages
GitHub Actions
Inactive
vibhorgoswami
temporarily deployed
to
github-pages
GitHub Actions
Inactive
witrisna
requested changes
May 26, 2026
vibhorgoswami
temporarily deployed
to
github-pages
GitHub Actions
Inactive
vibhorgoswami
temporarily deployed
to
github-pages
GitHub Actions
Inactive
witrisna
approved these changes
Jun 4, 2026
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (5)
samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/config/EnvViewModel.kt (1)
392-395: 💤 Low valueMissing
buildDeviceAuthClientcall for consistency with other config types.The init block rebuilds Journey, DaVinci, and Web SDK instances from loaded configs, but does not rebuild the device auth client. While
initConfigs()already builds it at app startup, the pattern here ensures ViewModel state and SDK instance are synchronized.♻️ Suggested fix for consistency
buildJourneyInstance(jApplied) buildDaVinciInstance(dvApplied) buildWebInstance(wApplied) + buildDeviceAuthClient(daApplied) }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/config/EnvViewModel.kt` around lines 392 - 395, The init block currently calls buildJourneyInstance(jApplied), buildDaVinciInstance(dvApplied), and buildWebInstance(wApplied) but omits rebuilding the device auth client; add a call to buildDeviceAuthClient(dacApplied) (or the appropriate variable name used for device-auth configs) alongside those other calls in the same init block so the ViewModel state and SDK instance remain synchronized with initConfigs()’s startup behavior.samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/token/Token.kt (4)
187-195: ⚡ Quick winExternalize token field labels.
The token field labels ("Access Token", "Refresh Token", "ID Token", "Token Type", "Scope") are hardcoded. Move these to
strings.xmlfor i18n consistency.♻️ Proposed fix
Add to
strings.xml:<string name="token_label_access">Access Token</string> <string name="token_label_refresh">Refresh Token</string> <string name="token_label_id">ID Token</string> <string name="token_label_type">Token Type</string> <string name="token_label_scope">Scope</string>Then update TokenCard:
+import androidx.compose.ui.res.stringResource +import com.pingidentity.samples.pingsampleapp.R @@ `@Composable` private fun TokenCard(token: Token) { - TokenFieldCard(label = "Access Token", value = token.accessToken) - token.refreshToken?.let { TokenFieldCard(label = "Refresh Token", value = it) } - token.idToken?.let { TokenFieldCard(label = "ID Token", value = it) } - token.tokenType?.let { TokenFieldCard(label = "Token Type", value = it, truncate = false, copyable = false) } - token.scope?.let { TokenFieldCard(label = "Scope", value = it, truncate = false, copyable = false) } + TokenFieldCard(label = stringResource(R.string.token_label_access), value = token.accessToken) + token.refreshToken?.let { TokenFieldCard(label = stringResource(R.string.token_label_refresh), value = it) } + token.idToken?.let { TokenFieldCard(label = stringResource(R.string.token_label_id), value = it) } + token.tokenType?.let { TokenFieldCard(label = stringResource(R.string.token_label_type), value = it, truncate = false, copyable = false) } + token.scope?.let { TokenFieldCard(label = stringResource(R.string.token_label_scope), value = it, truncate = false, copyable = false) } ExpiryCountdownCard(token = token) }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/token/Token.kt` around lines 187 - 195, The hardcoded labels in TokenCard should be moved to resources: add the five strings (token_label_access, token_label_refresh, token_label_id, token_label_type, token_label_scope) to strings.xml and update TokenCard to fetch and pass those localized strings to TokenFieldCard (and keep truncate/copyable flags as-is); locate and modify the TokenCard composable and any calls to TokenFieldCard/ExpiryCountdownCard to use stringResource(R.string.token_label_...) for each label so the UI is internationalized.
220-226: ⚡ Quick winExternalize countdown display strings.
The "Expired" status text (line 220) and "Expires In" label (line 226) are hardcoded and should be moved to
strings.xmlfor i18n consistency.♻️ Proposed fix
Add to
strings.xml:<string name="token_expired">Expired</string> <string name="token_expires_in">Expires In</string>Then update:
+import androidx.compose.ui.res.stringResource +import com.pingidentity.samples.pingsampleapp.R @@ - val countdownText = if (expired) "Expired" + val countdownText = if (expired) stringResource(R.string.token_expired) @@ TokenFieldCard( - label = "Expires In", + label = stringResource(R.string.token_expires_in),🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/token/Token.kt` around lines 220 - 226, Move the hardcoded UI strings into resource strings: replace the "Expired" literal used in countdownText and the "Expires In" literal passed to TokenFieldCard with references to string resources (e.g., R.string.token_expired and R.string.token_expires_in). Add the two entries token_expired and token_expires_in to strings.xml, then update the code paths that set countdownText and the TokenFieldCard label to fetch context.getString(R.string.token_expired) and context.getString(R.string.token_expires_in) (or use stringResource in Compose) so the UI uses the new resources.
80-108: ⚡ Quick winExternalize contentDescription strings for accessibility and i18n.
The
contentDescriptionvalues for the TopAppBar action icons are hardcoded. These accessibility strings should be externalized tostrings.xmlfor consistency with i18n best practices.♻️ Proposed fix
Add to
strings.xml:<string name="content_desc_access_token">Access Token</string> <string name="content_desc_refresh">Refresh</string> <string name="content_desc_revoke">Revoke</string> <string name="content_desc_clear">Clear</string>Then update the code:
+import androidx.compose.ui.res.stringResource +import com.pingidentity.samples.pingsampleapp.R @@ - contentDescription = "Access Token", + contentDescription = stringResource(R.string.content_desc_access_token), @@ - contentDescription = "Refresh", + contentDescription = stringResource(R.string.content_desc_refresh), @@ - contentDescription = "Revoke", + contentDescription = stringResource(R.string.content_desc_revoke), @@ - contentDescription = "Clear", + contentDescription = stringResource(R.string.content_desc_clear),🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/token/Token.kt` around lines 80 - 108, Replace hardcoded contentDescription literals on the TopAppBar action IconButton calls with resource lookups: add string resources for "Access Token", "Refresh", "Revoke", and "Clear" (e.g., content_desc_access_token, content_desc_refresh, content_desc_revoke, content_desc_clear) in strings.xml and then use stringResource(...) for the contentDescription parameter in the Icon composables inside the IconButton callbacks (the ones invoking tokenViewModel.accessToken(), tokenViewModel.refresh(), tokenViewModel.revoke(), tokenViewModel.reset()) so that accessibility text is externalized for i18n.
308-321: ⚡ Quick winExternalize empty state message template.
The empty state message template can be externalized using a string resource with a placeholder for i18n support.
♻️ Proposed fix
Add to
strings.xml:<string name="token_empty_message">No %s token available</string>Then update:
+import androidx.compose.ui.res.stringResource +import com.pingidentity.samples.pingsampleapp.R @@ Text( - text = "No ${tab.name.lowercase().replaceFirstChar { it.uppercase() }} token available", + text = stringResource( + R.string.token_empty_message, + tab.name.lowercase().replaceFirstChar { it.uppercase() } + ),🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/token/Token.kt` around lines 308 - 321, Replace the hardcoded empty-state text in the EmptyCard composable with a string resource that has a placeholder (e.g. token_empty_message = "No %s token available") to enable i18n; in EmptyCard (which takes TokenType tab) call stringResource(...) and pass the formatted tab name (keeping the same lowercase/uppercase transform you currently use on tab.name) instead of the inline string, and ensure you add the new string to strings.xml and import androidx.compose.ui.res.stringResource.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/config/EnvViewModel.kt`:
- Around line 392-395: The init block currently calls
buildJourneyInstance(jApplied), buildDaVinciInstance(dvApplied), and
buildWebInstance(wApplied) but omits rebuilding the device auth client; add a
call to buildDeviceAuthClient(dacApplied) (or the appropriate variable name used
for device-auth configs) alongside those other calls in the same init block so
the ViewModel state and SDK instance remain synchronized with initConfigs()’s
startup behavior.
In
`@samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/token/Token.kt`:
- Around line 187-195: The hardcoded labels in TokenCard should be moved to
resources: add the five strings (token_label_access, token_label_refresh,
token_label_id, token_label_type, token_label_scope) to strings.xml and update
TokenCard to fetch and pass those localized strings to TokenFieldCard (and keep
truncate/copyable flags as-is); locate and modify the TokenCard composable and
any calls to TokenFieldCard/ExpiryCountdownCard to use
stringResource(R.string.token_label_...) for each label so the UI is
internationalized.
- Around line 220-226: Move the hardcoded UI strings into resource strings:
replace the "Expired" literal used in countdownText and the "Expires In" literal
passed to TokenFieldCard with references to string resources (e.g.,
R.string.token_expired and R.string.token_expires_in). Add the two entries
token_expired and token_expires_in to strings.xml, then update the code paths
that set countdownText and the TokenFieldCard label to fetch
context.getString(R.string.token_expired) and
context.getString(R.string.token_expires_in) (or use stringResource in Compose)
so the UI uses the new resources.
- Around line 80-108: Replace hardcoded contentDescription literals on the
TopAppBar action IconButton calls with resource lookups: add string resources
for "Access Token", "Refresh", "Revoke", and "Clear" (e.g.,
content_desc_access_token, content_desc_refresh, content_desc_revoke,
content_desc_clear) in strings.xml and then use stringResource(...) for the
contentDescription parameter in the Icon composables inside the IconButton
callbacks (the ones invoking tokenViewModel.accessToken(),
tokenViewModel.refresh(), tokenViewModel.revoke(), tokenViewModel.reset()) so
that accessibility text is externalized for i18n.
- Around line 308-321: Replace the hardcoded empty-state text in the EmptyCard
composable with a string resource that has a placeholder (e.g.
token_empty_message = "No %s token available") to enable i18n; in EmptyCard
(which takes TokenType tab) call stringResource(...) and pass the formatted tab
name (keeping the same lowercase/uppercase transform you currently use on
tab.name) instead of the inline string, and ensure you add the new string to
strings.xml and import androidx.compose.ui.res.stringResource.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 6aab32e6-574a-4e58-8b8f-3cae53c03a48
📒 Files selected for processing (20)
gradle/libs.versions.tomlsamples/pingsampleapp/build.gradle.ktssamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/authgrant/ApproveDeviceScreen.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/authgrant/DeviceAuthorizationGrantScreen.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/authgrant/DeviceAuthorizationGrantViewModel.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/config/Env.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/config/EnvViewModel.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/davinci/DaVinci.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/davinci/DaVinciViewModel.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/home/HomeApp.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/journey/JourneyViewModel.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/logout/Logout.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/logout/LogoutViewModel.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/navigation/Navigation.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/token/Token.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/token/TokenState.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/token/TokenViewModel.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/userprofile/UserProfile.ktsamples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/userprofile/UserProfileViewModel.ktsamples/pingsampleapp/src/main/res/values/strings.xml
✅ Files skipped from review due to trivial changes (1)
- gradle/libs.versions.toml
🚧 Files skipped from review as they are similar to previous changes (17)
- samples/pingsampleapp/src/main/res/values/strings.xml
- samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/home/HomeApp.kt
- samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/davinci/DaVinci.kt
- samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/token/TokenState.kt
- samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/userprofile/UserProfile.kt
- samples/pingsampleapp/build.gradle.kts
- samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/davinci/DaVinciViewModel.kt
- samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/journey/JourneyViewModel.kt
- samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/logout/Logout.kt
- samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/authgrant/ApproveDeviceScreen.kt
- samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/token/TokenViewModel.kt
- samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/logout/LogoutViewModel.kt
- samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/authgrant/DeviceAuthorizationGrantViewModel.kt
- samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/config/Env.kt
- samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/userprofile/UserProfileViewModel.kt
- samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/authgrant/DeviceAuthorizationGrantScreen.kt
- samples/pingsampleapp/src/main/java/com/pingidentity/samples/pingsampleapp/navigation/Navigation.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
SDKS-5026
Description
Introduces the test feature for Device Authorization Grant. Shows the option for QR code/User Code/Verification URL to authenticate the device.
Summary by CodeRabbit