fix: initialize src path in WriteCode.run for incremental mode#2011
Open
ztexydt-cqh wants to merge 1 commit into
Open
fix: initialize src path in WriteCode.run for incremental mode#2011ztexydt-cqh wants to merge 1 commit into
ztexydt-cqh wants to merge 1 commit into
Conversation
Author
|
@geekan This PR fixes the ValueError: "Call with_srcs first." crash in WriteCode when running in incremental mode (#2007). The fix initializes the src path in WriteCode.run() before using it, which resolves the crash. Unit tests have passed, but the Full Tests workflow is pending approval. Could you please approve the CI workflow for this PR so the full tests can run? Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2007.