Skip to content

Fix rlm_totp and add new test suite#5201

Open
jpereira wants to merge 4 commits intoFreeRADIUS:masterfrom
jpereira:v4/fix-rlm_totp
Open

Fix rlm_totp and add new test suite#5201
jpereira wants to merge 4 commits intoFreeRADIUS:masterfrom
jpereira:v4/fix-rlm_totp

Conversation

@jpereira
Copy link
Copy Markdown
Contributor

@jpereira jpereira commented Oct 4, 2023

eg:

[jpereira@sugarloaf:freeradius-server.git]$ make
CC src/modules/rlm_totp/rlm_totp.c
LINK build/lib/rlm_totp.la
[jpereira@sugarloaf:freeradius-server.git]$ make test.totp
TOTP-TEST INPUT=now_token_6digits.txt TOKEN=089002 TOTP_GEN_ARGV="-d 6 -D sha1"
TOTP-TEST INPUT=now_token_8digits.txt TOKEN=68089002 TOTP_GEN_ARGV="-d 8 -D sha1"
[jpereira@sugarloaf:freeradius-server.git]$

* That script get a real token using scripts/totp/totp-gen.py
* It's validate using 'radclient' sending a valid packet.
The 'nullable' field should be true.
The user TOTP token is expected over 'contro.TOTP.From-User'
.method_names = (module_method_name_t[]){
{ .name1 = "authenticate", .name2 = CF_IDENT_ANY, .method = mod_authenticate, .method_env = &method_env },
{ .name1 = "authenticate", .name2 = CF_IDENT_ANY, .method = mod_authenticate, .method_env = &method_env },
{ .name1 = CF_IDENT_ANY, .name2 = CF_IDENT_ANY, .method = mod_authenticate, .method_env = &method_env },
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not clear why this is necessary? The totp module really should only be authenticating users.

I guess that it could go anywhere to authenticate users, but we generally put the pap, chap, etc. authentications into an authenticate section

@arr2036 arr2036 force-pushed the master branch 4 times, most recently from 76ed4dd to 48ca41e Compare May 16, 2024 00:49
@arr2036 arr2036 force-pushed the master branch 2 times, most recently from 78c97fd to 1a249f5 Compare September 2, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants