Add BCP truncation surveys and logistical support for them.#598
Open
ucko wants to merge 2 commits into
Open
Conversation
... for comparison purposes.
* sqldb.h: Don't insist on the accompanying sybdb.h, which might clash
with Sybase headers or result in skew with Sybase libraries.
* sqlfront.h: Likewise for sybfront.h; moreover, additionally pull in
sybdb.h and don't rely on having USHORT.
* ctlib tests: Use centrally defined UT_{CS,BLK}_VERSION macros rather
than hardcoding {CS,BLK}_VERSION_100, which could result in
blk_describe failure when run against modern servers. Allow both to
be overridden, but default UT_CS_VERSION to CS_CURRENT_VERSION where
available (falling back on CS_VERSION_160) and UT_BLK_VERSION to
UT_CS_VERSION because the numbers always match up in practice.
Signed-off-by: Aaron M. Ucko <ucko@ncbi.nlm.nih.gov>
They don't enforce specific results, just note them all in tabular form to facilitate comparison with Sybase libraries' behavior. Signed-off-by: Aaron M. Ucko <ucko@ncbi.nlm.nih.gov>
Contributor
|
When run against MSSQL 15.0.2155.2, after rebasing to
|
Contributor
|
Test c_blk_in3 takes prohibitively long to run, against a remote database -- against ASE 16.0 with about 200ms ping latency, it took 9 minutes to complete half of the first of what appears to be about 20 rounds of tests. The test coverage is extremely detailed, and each case starts with a To make this test viable (with remote database) we might need to come up with a way of optimizing repeated Against local MSSQL 15.0.2155.2 , a stream error occurs on one of the early tests, and the test exits with a success status. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were helpful in crafting 3176598 and #595.