Skip to content

Add disallow_uri_schemes() function for disallowing javascript: URIs#65

Merged
Alkarex merged 8 commits into
FreshRSS:freshrssfrom
Inverle:frss-sp-sanitize-uri
Jun 13, 2026
Merged

Add disallow_uri_schemes() function for disallowing javascript: URIs#65
Alkarex merged 8 commits into
FreshRSS:freshrssfrom
Inverle:frss-sp-sanitize-uri

Conversation

@Inverle

@Inverle Inverle commented Nov 29, 2025

Copy link
Copy Markdown
Member

FreshRSS/FreshRSS#8263

TODO:

  • write unit test

@Inverle Inverle force-pushed the frss-sp-sanitize-uri branch 2 times, most recently from e647e1f to 56c5d91 Compare November 29, 2025 14:25
@Inverle Inverle force-pushed the frss-sp-sanitize-uri branch from 56c5d91 to 53737d1 Compare November 29, 2025 14:35
@Alkarex

Alkarex commented Jun 12, 2026

Copy link
Copy Markdown
Member

Comments / tests welcome on the refactoring, @Inverle
dc32e35

@Inverle

Inverle commented Jun 13, 2026

Copy link
Copy Markdown
Member Author

Comments / tests welcome on the refactoring, @Inverle dc32e35

Looks good to me. I added some more tests: 122afae

@Alkarex Alkarex merged commit 73ac635 into FreshRSS:freshrss Jun 13, 2026
10 checks passed
@Inverle Inverle deleted the frss-sp-sanitize-uri branch June 13, 2026 16:09
@Inverle

Inverle commented Jun 13, 2026

Copy link
Copy Markdown
Member Author

The commit message is inaccurate now because of the function name change in the refactor though

@Inverle Inverle changed the title Add disallow_uri_protocols() function for disallowing javascript: URIs Add disallow_uri_schemes() function for disallowing javascript: URIs Jun 13, 2026
Alkarex pushed a commit that referenced this pull request Jun 13, 2026
Alkarex added a commit to FreshRSS/FreshRSS that referenced this pull request Jun 13, 2026
Follow-up of #7924
FreshRSS/simplepie#80
FreshRSS/simplepie#65

* SimplePie: Disallow `javascript:` URI protocol

* Sync SimplePie

* Update code to work with SimplePie again

* Partial revert previous commit

* Bump SimplePie

---------

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants