Reuse global ACP config for remote agents#766
Open
wgqqqqq wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nvm,.local/bin,.cargo/bin,.npm-global/bin) and safely applies configured env before probing or starting the client.Why
Remote ACP behavior was mixing two models: local settings controlled normal ACP clients, while remote workspaces used virtual built-in presets and fixed commands. That made local and remote color/status semantics diverge and made it unclear whether a remote server was using the user's actual ACP config.
This PR makes
acpClientsthe single source of truth. Remote servers no longer get separate override controls in the settings UI; they reuse the global config and only maintain their own detected capability state.User impact
available / totaland concrete next steps instead of a generic config error.Validation
pnpm --dir src/web-ui run test:runcargo test -p bitfun-acpcargo check --workspacegit diff --check